Improve tests [DI-337] #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
JackPGreen
force-pushed
the
improve-tests
branch
from
fdcef83 to
648c9da
Compare
I don't think so. |
|
@ldziedziul are you able to take a look at this, please? |
ldziedziul
approved these changes
Nov 20, 2024
JackPGreen
added a commit
to hazelcast/management-center-packaging
that referenced
this pull request
Nov 20, 2024
JackPGreen
added a commit
that referenced
this pull request
Nov 28, 2024
#237 highlighted a gap in our test process, investigation found further issues this PR addresses: - We test Debian packages on Ubuntu - A better target would be Debian, action updated to use `debian:latest` and install required tools - Note that this means the **build now fails** because the fix for #237 has yet to be merged - this is a good thing, as we've recreated the issue - Unnecessary Java installation - The Debian package specifies a JRE, we don't need to install our own - This didn't obscure the issue in #237, but if there was an incompatibility in Java versions, it might've been hidden - Test repo not reliably cleaned - The test undeploys the packages from the test repo, but _only_ if it completes successfully - when it [fails](https://github.com/hazelcast/hazelcast-packaging/actions/runs/11727659937/job/32669285892), it's not removed Fixes: [DI-337](https://hazelcast.atlassian.net/browse/DI-337) [DI-337]: https://hazelcast.atlassian.net/browse/DI-337?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
JackPGreen
added a commit
that referenced
this pull request
Nov 28, 2024
#237 highlighted a gap in our test process, investigation found further issues this PR addresses: - We test Debian packages on Ubuntu - A better target would be Debian, action updated to use `debian:latest` and install required tools - Note that this means the **build now fails** because the fix for #237 has yet to be merged - this is a good thing, as we've recreated the issue - Unnecessary Java installation - The Debian package specifies a JRE, we don't need to install our own - This didn't obscure the issue in #237, but if there was an incompatibility in Java versions, it might've been hidden - Test repo not reliably cleaned - The test undeploys the packages from the test repo, but _only_ if it completes successfully - when it [fails](https://github.com/hazelcast/hazelcast-packaging/actions/runs/11727659937/job/32669285892), it's not removed Fixes: [DI-337](https://hazelcast.atlassian.net/browse/DI-337) [DI-337]: https://hazelcast.atlassian.net/browse/DI-337?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
This was referenced Nov 28, 2024
1 task
JackPGreen
added a commit
that referenced
this pull request
Nov 28, 2024
`apt install` prompts for confirmation, which caused the job to fail when not specified - with the newly added option, this is avoided. Note that I do not understand why this is only _now_ causing a problem, as recent changes do not explain it: - #220 - I can reproduce this issue with both `apt-get` and `apt` - #241 - I can reproduce this issue with both Ubuntu and Debian I think it should _always_ have failed. Fixes: [DI-358](https://hazelcast.atlassian.net/browse/DI-358) [DI-358]: https://hazelcast.atlassian.net/browse/DI-358?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
JackPGreen
added a commit
that referenced
this pull request
Nov 28, 2024
`apt install` prompts for confirmation, which caused the job to fail when not specified - with the newly added option, this is avoided. Note that I do not understand why this is only _now_ causing a problem, as recent changes do not explain it: - #220 - I can reproduce this issue with both `apt-get` and `apt` - #241 - I can reproduce this issue with both Ubuntu and Debian I think it should _always_ have failed. Fixes: [DI-358](https://hazelcast.atlassian.net/browse/DI-358) [DI-358]: https://hazelcast.atlassian.net/browse/DI-358?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
JackPGreen
added a commit
that referenced
this pull request
Nov 28, 2024
`apt install` prompts for confirmation, which caused the job to fail when not specified - with the newly added option, this is avoided. Note that I do not understand why this is only _now_ causing a problem, as recent changes do not explain it: - #220 - I can reproduce this issue with both `apt-get` and `apt` - #241 - I can reproduce this issue with both Ubuntu and Debian I think it should _always_ have failed. Fixes: [DI-358](https://hazelcast.atlassian.net/browse/DI-358) [DI-358]: https://hazelcast.atlassian.net/browse/DI-358?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
JackPGreen
added a commit
that referenced
this pull request
Nov 28, 2024
`apt install` prompts for confirmation, which caused the job to fail when not specified - with the newly added option, this is avoided. Note that I do not understand why this is only _now_ causing a problem, as recent changes do not explain it: - #220 - I can reproduce this issue with both `apt-get` and `apt` - #241 - I can reproduce this issue with both Ubuntu and Debian I think it should _always_ have failed. Fixes: [DI-358](https://hazelcast.atlassian.net/browse/DI-358) [DI-358]: https://hazelcast.atlassian.net/browse/DI-358?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
JackPGreen
added a commit
that referenced
this pull request
Nov 28, 2024
`apt install` prompts for confirmation, which caused the job to fail when not specified - with the newly added option, this is avoided. Note that I do not understand why this is only _now_ causing a problem, as recent changes do not explain it: - #220 - I can reproduce this issue with both `apt-get` and `apt` - #241 - I can reproduce this issue with both Ubuntu and Debian I think it should _always_ have failed. Fixes: [DI-358](https://hazelcast.atlassian.net/browse/DI-358) [DI-358]: https://hazelcast.atlassian.net/browse/DI-358?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
JackPGreen
added a commit
that referenced
this pull request
Nov 30, 2024
`apt install` prompts for confirmation, which caused the job to fail when not specified - with the newly added option, this is avoided. Note that I do not understand why this is only _now_ causing a problem, as recent changes do not explain it: - #220 - I can reproduce this issue with both `apt-get` and `apt` - #241 - I can reproduce this issue with both Ubuntu and Debian I think it should _always_ have failed. Fixes: [DI-358](https://hazelcast.atlassian.net/browse/DI-358) [DI-358]: https://hazelcast.atlassian.net/browse/DI-358?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
JackPGreen
added a commit
that referenced
this pull request
Nov 30, 2024
`apt install` prompts for confirmation, which caused the job to fail when not specified - with the newly added option, this is avoided. Note that I do not understand why this is only _now_ causing a problem, as recent changes do not explain it: - #220 - I can reproduce this issue with both `apt-get` and `apt` - #241 - I can reproduce this issue with both Ubuntu and Debian I think it should _always_ have failed. Fixes: [DI-358](https://hazelcast.atlassian.net/browse/DI-358) [DI-358]: https://hazelcast.atlassian.net/browse/DI-358?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#237 highlighted a gap in our test process, investigation found further issues this PR addresses:
debian:latestand install required toolsFixes: DI-337
Post-merge action: