WIP [REFACTORING] Use black for autoformatting #4453
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To prevent needless discussions on code style, pep8/pyflakes (together flake8) is already used to enforce a coding standard and prevent python errors. The program
black
makes things even simpler and completely standardizes the way that python code is formatted. This PR does a couple of things:Applying black to all code is a MASSIVE change, so don't hesitate to pause this PR and see what the rest of the community thinks.
Pros for applying black:
Cons:
It's a bit of a mix between a CHORE and REFACTORING. No code is functionally changed. For the code review, only look at commit 836a027 as editing the test code to not use lambdas was done by hand.
Mentioned in discussion #4447
What more can I say.
How to test
To verify nothing else was changed do the following:
black
git diff c4ea7b6b14cd2c18cf00a87fb884bbb623849286
(currently that is the commit in this PR that applies black)Checklist