Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocking DBClient Part 2 #7187

Closed
2 tasks done
barchetta opened this issue Jul 13, 2023 · 1 comment · Fixed by #7231
Closed
2 tasks done

Blocking DBClient Part 2 #7187

barchetta opened this issue Jul 13, 2023 · 1 comment · Fixed by #7231
Assignees
@romain-grecourt @Tomas-Kraus
Labels
4.x Version 4.x DB client Helidon DB Client epic
Milestone
4.0.0

Comments

@barchetta
Copy link
Member

barchetta commented Jul 13, 2023 •
edited
Loading

Second phase of blocking DBClient work (post M1):

  • Fix examples to handle transactions in try/catch blocks, so the transaction is always either committed or rolled-back
  • Enabled disabled tests
@barchetta barchetta added epic DB client Helidon DB Client 4.x Version 4.x labels Jul 13, 2023
@barchetta barchetta added this to the 4.0.0-M2 milestone Jul 13, 2023
@barchetta barchetta mentioned this issue Jul 14, 2023
Closed
@Tomas-Kraus
Copy link
Member

Tomas-Kraus commented Jul 21, 2023 •
edited
Loading

@barchetta I'd like to do a bit more in this area. I prepared refactored version with few things that was removed by @romain-grecourt because of time pressure during reactive removal.
I'll start with fixing tests and examples 1st but it would be nice to get those removed things back too.

Edit: added #7230 to address this.

Tomas-Kraus added a commit to Tomas-Kraus/helidon that referenced this issue Jul 21, 2023
@Tomas-Kraus
Issue helidon-io#7187 - Fix examples to handle transactions in try/ca…
24475c2 
…tch blocks, so the transaction is always either committed or rolled-back

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
@Tomas-Kraus Tomas-Kraus linked a pull request Jul 21, 2023 that will close this issue
Issue #7187 - Blocking DBClient Part 2 #7231
Merged
Tomas-Kraus added a commit that referenced this issue Jul 24, 2023
@Tomas-Kraus
Issue #7187 - Fix examples to handle transactions in try/catch blocks…
b7a5d46 
…, so the transaction is always either committed or rolled-back

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
@barchetta barchetta modified the milestones: 4.0.0-M2, 4.0.0-RC1 Aug 28, 2023
@barchetta barchetta modified the milestones: 4.0.0-RC1, 4.0.0 Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romain-grecourt romain-grecourt

@Tomas-Kraus Tomas-Kraus

Labels
4.x Version 4.x DB client Helidon DB Client epic
Projects
Backlog
Archived in project
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Issue #7187 - Blocking DBClient Part 2 Tomas-Kraus/helidon
3 participants
@romain-grecourt @barchetta @Tomas-Kraus