Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocking DBClient Part 3 #7230

Closed
Tomas-Kraus opened this issue Jul 21, 2023 · 2 comments
Closed

Blocking DBClient Part 3 #7230

Tomas-Kraus opened this issue Jul 21, 2023 · 2 comments
Assignees
@Tomas-Kraus
Labels
4.x Version 4.x DB client Helidon DB Client wontfix This will not be worked on
Milestone
4.0.0

Comments

@Tomas-Kraus
Copy link
Member

Tomas-Kraus commented Jul 21, 2023 •
edited
Loading

This changeset https://github.com/Tomas-Kraus/helidon/tree/c79f29915285575b50c473d7790484ccbb0f7170/dbclient contains some changes that were removed from DB client during reactive removal.
It would be nice to get them back.
There are 3 main parts to get back:

  1. restore common module wit all common parts that are just copy-pasted in jdbc/mongo, restore removed config/context objects
  2. restore optimized query parameters processing and make it slightly better (I remember Romain had some design note to it)
  3. restore JDBC type specific setters and primitive types auto boxing removal (currently everything is set trough setObject which is not optimal)
@Tomas-Kraus Tomas-Kraus mentioned this issue Jul 21, 2023
Closed
2 tasks
@Tomas-Kraus Tomas-Kraus self-assigned this Jul 21, 2023
@Tomas-Kraus Tomas-Kraus added DB client Helidon DB Client 4.x Version 4.x labels Jul 21, 2023
@Tomas-Kraus
Copy link
Member Author

Had some discussion with @tomas-langer and @romain-grecourt about this task.

  1. We won't restore common module. Common abstract classes will remain part of API
  2. Optimization won't be done now. Query parameters processing won't be redesigned.
  3. JDBC type specific setters will be called the same way as in EclipseLink.

Tomas-Kraus added a commit to Tomas-Kraus/helidon that referenced this issue Jul 25, 2023
@Tomas-Kraus
Issue helidon-io#7230 - JDBC type specific setters based on EclipseLink
7565ebe 
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Tomas-Kraus added a commit to Tomas-Kraus/helidon that referenced this issue Jul 25, 2023
@Tomas-Kraus
Issue helidon-io#7230 - JDBC type specific setters based on EclipseLink
ac254fb 
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Tomas-Kraus added a commit to Tomas-Kraus/helidon that referenced this issue Jul 25, 2023
@Tomas-Kraus
Issue helidon-io#7230 - JDBC type specific setters based on EclipseLink
2945b44 
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Tomas-Kraus added a commit to Tomas-Kraus/helidon that referenced this issue Jul 25, 2023
@Tomas-Kraus
Issue helidon-io#7230 - JDBC type specific setters based on EclipseLink
a450be2 
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
romain-grecourt pushed a commit that referenced this issue Jul 25, 2023
@Tomas-Kraus
Issue #7230 - JDBC type specific setters based on EclipseLink (#7246)
7442d44 
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
@m0mus m0mus added this to the 4.0.0-M2 milestone Jul 27, 2023
@barchetta barchetta modified the milestones: 4.0.0-M2, 4.0.0-RC1 Sep 5, 2023
@barchetta barchetta modified the milestones: 4.0.0-RC1, 4.0.0 Sep 18, 2023
@romain-grecourt romain-grecourt added the wontfix This will not be worked on label Oct 9, 2023
@Tomas-Kraus
Copy link
Member Author

Tomas-Kraus commented Oct 9, 2023 •
edited
Loading

1 and 2 - we decided to not implement those features.
3 is already done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tomas-Kraus Tomas-Kraus

Labels
4.x Version 4.x DB client Helidon DB Client wontfix This will not be worked on
Projects
Backlog
Archived in project
Milestone
4.0.0
Development

No branches or pull requests
4 participants
@romain-grecourt @barchetta @m0mus @Tomas-Kraus