#5717 - Nima WebServer.stop() is slow / not timely when there are no active requests #5748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not timely when there are no active requests
…mely Nima WebServer.stop()
…o currentlyReadingPrologue
…leTask() shutdown() is modified to call the new tryStopInterruptableTask() method which identifies task that are InterruptableTask.canInterrupt() true and interrupts those threads
…17-WebServerStop-isNotTimely-2
oracle-contributor-agreement
bot
added
the
OCA Verified
This was referenced Dec 22, 2022
spericas
added a commit
to spericas/helidon
that referenced
this pull request
Jan 19, 2023
…or more information see issue helidon-io#5717. This approach is based on that described in PR helidon-io#5748. It includes a simple executor SPI for tasks that are immediately interruptable, such as those waiting to read connection preambles. Some new tests that verify faster webserver shutdown.
spericas
added a commit
that referenced
this pull request
Jan 27, 2023
…5876) * Proposal to implement a more efficient webserver shutdown strategy. For more information see issue #5717. This approach is based on that described in PR #5748. It includes a simple executor SPI for tasks that are immediately interruptable, such as those waiting to read connection preambles. Some new tests that verify faster webserver shutdown. * Updated copyright year. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Removed print statements and fixed logging. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Fixed checkstyle. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Avoid using @servertest when stopping server manually. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Dropped SPI for tasks, moved interfaces into webserver package. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Fixed checkstyle. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Make interface package private. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> --------- Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
|
This should be fixed by #5876, I think this PR no longer makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch current has 2 tests and 2 approaches to solving this issue.
The latest commit solves the issue using a modified/hacked version of
ThreadPerTaskExecutorand a new interfaceInterruptibleTask(and this approaches points to trying to get a similar change to the JDK).The prior solution used application code to maintain the active
Http1Connectionwhich duplicates functionality ofThreadPerTaskExecutorand as such doesn't appeal as an elegant solution.