Proposal to implement a more efficient webserver shutdown strategy #5876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
…or more information see issue helidon-io#5717. This approach is based on that described in PR helidon-io#5748. It includes a simple executor SPI for tasks that are immediately interruptable, such as those waiting to read connection preambles. Some new tests that verify faster webserver shutdown.
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
tomas-langer
requested changes
Jan 20, 2023
.../webserver/src/test/java/io/helidon/nima/tests/integration/server/WebServerStopIdleTest.java
Outdated
Show resolved
Hide resolved
.../webserver/src/test/java/io/helidon/nima/tests/integration/server/WebServerStopOnlyTest.java
Outdated
Show resolved
Hide resolved
nima/webserver/webserver/src/main/java/io/helidon/nima/webserver/ThreadPerTaskExecutor.java
Outdated
Show resolved
Hide resolved
...ebserver/webserver/src/main/java/io/helidon/nima/webserver/task/spi/HelidonTaskExecutor.java
Outdated
Show resolved
Hide resolved
zimmi
reviewed
Jan 21, 2023
nima/webserver/webserver/src/main/java/io/helidon/nima/webserver/http1/Http1Connection.java
Show resolved
Hide resolved
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
|
@tomas-langer Verified that there is no impact on performance using plaintext. |
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
tomas-langer
approved these changes
Jan 27, 2023
ljnelson
reviewed
Jan 27, 2023
| * | ||
| * @param <T> type of value returned by task | ||
| */ | ||
| public interface InterruptableTask<T> extends Runnable, Callable<T> { |
There was a problem hiding this comment.
Misspelled; should be Interruptible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to implement a more efficient webserver shutdown strategy for Nima. For more information see issue #5717. This approach is based on that described in PR #5748. It includes a simple executor SPI for tasks that are immediately interruptable, such as those waiting to read connection preambles. Some new tests that verify faster webserver shutdown.
The core of this solution is credited to Rob Bygrave (@rbygrave).