Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP29: Multi-signature Keys #157

Closed
jamiew opened this issue Apr 22, 2021 · 14 comments
Closed

HIP29: Multi-signature Keys #157

jamiew opened this issue Apr 22, 2021 · 14 comments
Labels

Comments

@jamiew
Copy link
Contributor

jamiew commented Apr 22, 2021

Author(s): @xandkar, @Vagabond, Helium Systems, Inc. team
Start Date: 2021-04-19
Category: Technical
Initial PR: #154
Status: In Discussion

Rendered view:

https://github.com/helium/HIP/blob/master/0029-multisignature-keys.md

Summary:

Hotspot owners, HNT holders, and other Helium participants, have different ways to organize assets. This HIP proposes a multi-signature key which can be used to authorize a transaction on the Helium blockchain. This key is a composite of the scalar keys which can be combined to generate a minimal subset of signatures required to make a valid transaction.

@jamiew
Copy link
Contributor Author

jamiew commented May 1, 2021

There has been universally positive support for this HIP in GitHub commnents, Discord chats, the most recent community call and there were 100% "yes" votes from 49 people in a straw poll. In recognition of this I am pleased to recognize this HIP as approved by the Helium community and will update statuses accordingly.

image

@jamiew jamiew added approved and removed discussion labels May 1, 2021
jamiew added a commit that referenced this issue May 1, 2021
@jamiew
Copy link
Contributor Author

jamiew commented May 1, 2021

@xandkar @Vagabond would it be possible to link to any existing PRs in other repositories? Someone mentioned work was already in-flight

@xandkar
Copy link
Contributor

xandkar commented May 7, 2021

@jamiew here's what's been done so far:
Basic support: helium/libp2p-crypto#10
Payment test: helium/blockchain-core#777
Canonicalization of key order: helium/libp2p-crypto#13

@abhay
Copy link
Contributor

abhay commented Jun 11, 2021

Close as implemented @jamiew ?

@mfalkvidd
Copy link

Is there any info/documentation on how to use multisig?

@jamiew
Copy link
Contributor Author

jamiew commented Jun 30, 2021

@abhay yes please! Did this require a chainvar deployment? Do you have a favorite link to use for Deployed and/or Audit links?

@jamiew
Copy link
Contributor Author

jamiew commented Jun 30, 2021

Is there any info/documentation on how to use multisig?

It's currently only available for chainvar transactions, imagine more will be coming later

@abhay
Copy link
Contributor

abhay commented Sep 6, 2021

Propose closing this as deployed @jamiew?

@abhay
Copy link
Contributor

abhay commented Sep 6, 2021

Now deployed – Same details as #158

@jamiew jamiew added deployed and removed approved labels Sep 14, 2021
jamiew added a commit that referenced this issue Sep 14, 2021
jamiew added a commit that referenced this issue Sep 14, 2021
@jamiew jamiew closed this as completed Sep 14, 2021
@abhay
Copy link
Contributor

abhay commented Sep 14, 2021

Is there any info/documentation on how to use multisig?

It's currently only available for chainvar transactions, imagine more will be coming later

Actually not exactly. Chain vars use a different multisig model. This is for on chain accounts/keys.

@mfalkvidd
Copy link

If we can use multisig for accounts, some sort of documentation would be very useful.

@GrahamJenkins
Copy link

From what I have read, HIP 29 has been merged, however support for it needs to be added to helium-wallet. Until that has happened, there will be no effective way for users to utilize multi-sig, is that correct?

@mfalkvidd
Copy link

@GrahamJenkins yes that is correct

@abhay
Copy link
Contributor

abhay commented Feb 3, 2022

Initial support has been implemented in helium/helium-crypto-rs#21 and additional support will need to be added to the CLI parts of https://github.com/helium/helium-wallet-rs to consider the rust wallet complete.

@jamiew jamiew changed the title HIP 29: Multi-signature Keys HIP29: Multi-signature Keys Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants