-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultisigAddress implementation #278
Conversation
syuan100
commented
Feb 2, 2022
•
edited
Loading
edited
- Create MultisigAddress from multiple Address objects
Thanks for looking into multisig support! Adding cross-reference to |
@mfalkvidd I also saw that basic multisig functions have already been implemented in helium-crypto-rs: helium/helium-crypto-rs#21 Will be following this as a template |
Also, I raised this draft PR mostly for visibility so other people can jump on if necessary |
@mfalkvidd hello! I would like to have this reviewed for just the MultisigAddress implementation. Another developer will be doing the rest of the multisig work. Thank you! |
Actually I just saw that there is a new "address" package. Should I move MultisigAddress into that package instead? |
Ok I just went ahead and refactored. Additionally, had to fix a test during merge if that's ok.
|
Closing in favor of #290 |