Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultisigAddress implementation #278

Closed
wants to merge 8 commits into from
Closed

Conversation

syuan100
Copy link
Contributor

@syuan100 syuan100 commented Feb 2, 2022

  • Create MultisigAddress from multiple Address objects

@mfalkvidd
Copy link

Thanks for looking into multisig support!

Adding cross-reference to
helium/HIP#157
and
helium/helium-wallet-rs#221

@syuan100
Copy link
Contributor Author

syuan100 commented Feb 3, 2022

@mfalkvidd I also saw that basic multisig functions have already been implemented in helium-crypto-rs: helium/helium-crypto-rs#21

Will be following this as a template

@syuan100
Copy link
Contributor Author

syuan100 commented Feb 3, 2022

Also, I raised this draft PR mostly for visibility so other people can jump on if necessary

@syuan100 syuan100 changed the title WIP: Multisig MultisigAddress implementation Mar 31, 2022
@syuan100 syuan100 marked this pull request as ready for review March 31, 2022 15:41
@syuan100
Copy link
Contributor Author

@mfalkvidd hello! I would like to have this reviewed for just the MultisigAddress implementation.

Another developer will be doing the rest of the multisig work. Thank you!

@syuan100
Copy link
Contributor Author

Actually I just saw that there is a new "address" package. Should I move MultisigAddress into that package instead?

@syuan100
Copy link
Contributor Author

Ok I just went ahead and refactored. Additionally, had to fix a test during merge if that's ok.

const checksum = Buffer.from(bin.slice(-4))

@syuan100
Copy link
Contributor Author

Closing in favor of #290

@syuan100 syuan100 closed this Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants