Make gutters padding optional #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickfire
force-pushed
the
optional-gutter-padding
branch
2 times, most recently
from
5d84f97 to
ff9aff1
Compare
pickfire
commented
Jul 7, 2022
Comment on lines
+108
to
+112
| match gutter_type { | ||
| GutterType::Diagnostics => gutter::diagnostics_or_breakpoints, | ||
| GutterType::LineNumbers => gutter::line_numbers, | ||
| GutterType::Padding => gutter::padding, | ||
| }, |
There was a problem hiding this comment.
Not sure why but I can't seemed to keep these as a variable gutter and merge it with above match, maybe function name is different?
pickfire
commented
Jul 7, 2022
| @@ -38,7 +38,7 @@ hidden = false | |||
| | `shell` | Shell to use when running external commands. | Unix: `["sh", "-c"]`<br/>Windows: `["cmd", "/C"]` | | |||
| | `line-number` | Line number display: `absolute` simply shows each line's number, while `relative` shows the distance from the current line. When unfocused or in insert mode, `relative` will still show absolute line numbers. | `absolute` | | |||
| | `cursorline` | Highlight all lines with a cursor. | `false` | | |||
| | `gutters` | Gutters to display: Available are `diagnostics` and `line-numbers`, note that `diagnostics` also includes other features like breakpoints | `["diagnostics", "line-numbers"]` | | |||
| | `gutters` | Gutters to display: Available are `diagnostics` and `line-numbers` and `padding`, note that `diagnostics` also includes other features like breakpoints | `["diagnostics", "line-numbers", "padding"]` | | |||
There was a problem hiding this comment.
:set gutters diagnostics or :set gutters ["diagnostics"] doesn't seemed to work for me, the completion for it is also weird.
pickfire
force-pushed
the
optional-gutter-padding
branch
from
ff9aff1 to
5f4af43
Compare
If all gutters are removed, there are still an extra one padding, would be nice to remove that to save some space.
pickfire
force-pushed
the
optional-gutter-padding
branch
from
5f4af43 to
4c076d2
Compare
archseer
approved these changes
Jul 18, 2022
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
If all gutters are removed, there are still an extra one padding, would be nice to remove that to save some space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all gutters are removed, there are still an extra one padding, would be nice
to remove that to save some space.