undo change, no magically added space please, just add Spacer by default #3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aikomastboom
force-pushed
the
revert-extra-gutter-offset
branch
from
d16c082
to
e365f5e
Compare
helix-view/src/view.rs
Outdated
Comment on lines
121
to
123
| if !gutter_types.is_empty() { | ||
| gutter_offset += 1; | ||
| } |
There was a problem hiding this comment.
This is a margin that's meant to separate the gutters and the code, themed as background
See #3111
|
See the discussion here #3111 |
|
Ah, I see.. so now we need an extra option to set the width of the margin between gutter and tekst. As the automatic adding of 1 is still reverting #2996 :) |
aikomastboom
force-pushed
the
revert-extra-gutter-offset
branch
from
e42d9ce
to
b2f777a
Compare
aikomastboom
force-pushed
the
revert-extra-gutter-offset
branch
from
b2f777a
to
986cbf6
Compare
kirawi
added
A-helix-term
|
I believe this was made obsolete with the spacing changes included in #3890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the idea for #2996 was to be able to add a spacer if desired.
Looking ahead to #1623 I prefer to have that space filled by git status.
This PR reverts functionality to give this choice back to the user.