Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/drupal] Make liveness and readiness probes configurable #1375

Closed
wants to merge 4 commits into from

Conversation

scottrigby
Copy link
Member

Reasoning for this PR is explained in the values file comments:

Drupal core exposes /user/login to unauthenticated requests, making it a good
default liveness and readiness path. However, that may not always be the
case. For example, if the image value is overridden to an image containing a
module that alters that route, or an image that does not auto-install Drupal.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @scottrigby. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@scottrigby
Copy link
Member Author

Same version bump as #1232. Will update version as needed after one or the other is merged first.

@prydonius
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 7, 2017
@prydonius prydonius added code reviewed lgtm Indicates that a PR is ready to be merged. UX reviewed labels Jul 7, 2017
@viglesiasce
Copy link
Contributor

Closing in favor of #1449

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. code reviewed lgtm Indicates that a PR is ready to be merged. UX reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants