Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/drupal] Adds extra environment variables to the container #1419

Closed
wants to merge 2 commits into from

Conversation

scottrigby
Copy link
Member

@prydonius Now that #1232 is merged, some images need user defined environment variables.

BTW, this feels like something that could be generally useful for all charts. Perhaps something we could add to other existing stable/charts, as well as a new PR for chartutil. Any thoughts about that?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @scottrigby. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 3, 2017
@scottrigby
Copy link
Member Author

Version is bumped to the next MINOR, same as #1375.

@prydonius
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 7, 2017
@prydonius prydonius added code reviewed lgtm Indicates that a PR is ready to be merged. UX reviewed labels Jul 7, 2017
@viglesiasce
Copy link
Contributor

Closing in favor of #1449

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. code reviewed lgtm Indicates that a PR is ready to be merged. UX reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants