[stable/puppetserver] Add Puppet Server Helm Chart

[Xtigyro]

Is this a new chart

Yes, it is a new chart.

What this PR does / why we need it:

This PR deploys everything required to run in a flexible manner a Puppet Server in Kubernetes and be discoverable by internal and external to the K8s cluster Puppet Agents.

Checklist

• DCO signed
• Variables are documented in the README.md
• Title of the PR starts with chart name (e.g. [stable/chart])

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Xtigyro
To complete the pull request process, please assign mattfarina
You can assign the PR to them by writing /assign @mattfarina in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @Xtigyro. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Xtigyro]

/assign @mattfarina

[Xtigyro]

A bug in the official latest Docker image of PuppetDB was introduced 8 hours ago.
Tracking bug report: puppetlabs/pupperware#157.

It can be worked around by using the previous version of the image: 6.5.0.

If the review of the chart is going to start before the bug is resolved - let me know so that we can include the bug-free version - 6.5.0.

[Xtigyro]

@prydonius @lachie83
The PR is in a fully functional state again - a fix has been provided for issue: puppetlabs/pupperware#157.

[zanhsieh]

/ok-to-test

[zanhsieh]

/test pull-charts-e2e

[Xtigyro]

@zanhsieh @prydonius @lachie83

Tests - passed.

[zanhsieh]

@Xtigyro
Per @maorfr commented in kubernetes slack, we think it's better you host yourself. The value of helm chart or even a software is up-to-date, agile, and passion on it. Currently we are short of OWNERS to achieve that ideal state. See @maorfr previous comment below and learn how to self-hosting a helm chart:

#5071 (comment)

[Xtigyro]

@Xtigyro
Per @maorfr commented in kubernetes slack, we think it's better you host yourself. The value of helm chart or even a software is up-to-date, agile, and passion on it. Currently we are short of OWNERS to achieve that ideal state. See @maorfr previous comment below and learn how to self-hosting a helm chart:

#5071 (comment)

@zanhsieh @maorfr
Me (https://github.com/xtigyro), Scott Cressi (https://github.com/scottcressi) and Puppetlabs themselves agreed to keep up-to-date the chart.
About the support from Puppetlabs you can contact Morgan Rhodes (https://github.com/underscorgan).

Morgan, who is the main developer of the Pupperware repo of Puppetlabs, is going to be added to the OWNERS and Maintainers - morgan@puppet.com.

So we're going to keep it updated.

[Xtigyro]

/test pull-charts-e2e

[Xtigyro]

Once the tests completed fine but even though just the OWNERS and Chart.yaml were changed afterwards - now they fail with a timeout while deleting the K8s namespace.

Is that really a problem of the chart?

[zanhsieh]

@Xtigyro
If you would like to push this chart as stable, I suggest you slack (kubernetes.slack.com; search via their ids or names) to one of helm member to be a new chart as well as the OWNERS. Most of helm members are there, although they might immediately respond to you since we all have daily job(s).

[underscorgan]

👍

[maorfr]

Would it make sense for Puppet Labs to self host?

cc @underscorgan

[underscorgan]

@maorfr As far as I know we don't have an existing hosted helm registry but I can ask around and look into it.

[Xtigyro]

Finished some changes:

• Add Optional Static Data Volumes.
• Add Configurable PVC's Size.
• Add Optional PVC's Annotations.
• Add optional extra Pod Annotations.
• Add optional Pod Priority Scheduling.
• Add LICENSE.
• Add CHANGELOG.
• Update README.
• Add "nodeSelector", "affinity" and "tolerations" for Pod Deployments.
• Bump component versions. Bump chart version.
• Improve Values' comments.
• Fixes.

[Xtigyro]

• Add Ingress.
• Improve Tmpl Helpers.
• Improve NOTES.
• Plus: [stable/puppetserver] Add Puppet Server Helm Chart #17201 (comment)

@maorfr @underscorgan @zanhsieh

Some more useful stuff has been finished.

[Xtigyro]

• Add PV/PVC Selector.

[k8s-ci-robot]

@Xtigyro: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-charts-e2e	a09c244	link	/test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[scottrigby]

Hi 👋 new charts are no longer accepted to stable or incubator. See Status of the Project and Deprecation Timeline for more info about that.

Good news is you can host a Helm chart yourself on GitHub, use the same tools as this repo does for automatic Chart testing and releasing, and list your Helm repo on https://helm.hub.sh. Follow this issue for info about existing guidelines and upcoming improvements: https://github.com/helm/charts/issues/7800

@underscorgan ping on Slack if you need any help setting up the Helm repo at Puppet Labs 😸