Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

add Kubeinvaders #18724

Closed
wants to merge 9 commits into from
Closed

add Kubeinvaders #18724

wants to merge 9 commits into from

Conversation

lucky-sideburn
Copy link

No description provided.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lucky-sideburn
To complete the pull request process, please assign paulczar
You can assign the PR to them by writing /assign @paulczar in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Nov 8, 2019
@helm-bot helm-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @lucky-sideburn. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 8, 2019
@lucky-sideburn
Copy link
Author

/assign @paulczar

@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Nov 8, 2019
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). and removed Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Nov 8, 2019
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). and removed Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Nov 8, 2019
Signed-off-by: Eugenio Marzo <eugenio.marzo@sourcesense.com>
Signed-off-by: Eugenio Marzo <eugenio.marzo@sourcesense.com>
Signed-off-by: Eugenio Marzo <eugenio.marzo@sourcesense.com>
    Signed-off-by: Eugenio Marzo <eugenio.marzo@sourcesense.com>

Signed-off-by: Eugenio Marzo <eugenio.marzo@sourcesense.com>
        Signed-off-by: Eugenio Marzo <eugenio.marzo@sourcesense.com>

Signed-off-by: Eugenio Marzo <eugenio.marzo@sourcesense.com>
        Signed-off-by: Eugenio Marzo <eugenio.marzo@sourcesense.com>

Signed-off-by: Eugenio Marzo <eugenio.marzo@sourcesense.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Nov 8, 2019
@lucky-sideburn
Copy link
Author

Fixed circleci checks and commit messages :)

@zanhsieh
Copy link
Collaborator

zanhsieh commented Nov 9, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 9, 2019
@zanhsieh
Copy link
Collaborator

zanhsieh commented Nov 9, 2019

@lucky-sideburn
I would say a new chart should go thru incubator before reaching stable. Also, you should consider host your own. As per discussion with @maorfr :
#5071 (comment)

@lucky-sideburn
Copy link
Author

Ops sorry! You're right, I should pass through incubator. Should I close this pr?

@cpanato
Copy link
Member

cpanato commented Nov 9, 2019

@lucky-sideburn we are not accepting new charts in the incubator, only in the stable folder.
But we prefer you host yourself the charts

@lucky-sideburn
Copy link
Author

Ah ok. I already host chart there.

@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Nov 10, 2019
Signed-off-by: Eugenio Marzo <eugenio.marzo@sourcesense.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). and removed Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Nov 10, 2019
@lucky-sideburn
Copy link
Author

/retest

Signed-off-by: Eugenio Marzo <eugenio.marzo@sourcesense.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Nov 11, 2019
Signed-off-by: Eugenio Marzo <eugenio.marzo@sourcesense.com>
@lucky-sideburn
Copy link
Author

hi! passed all automatic tests

@lucky-sideburn
Copy link
Author

@cpanato is it ok for merge?

@scottrigby
Copy link
Member

Hi 👋 new charts are no longer accepted to stable or incubator. See Status of the Project and Deprecation Timeline for more info about that.

Good news is you can host a Helm chart yourself on GitHub, use the same tools as this repo does for automatic Chart testing and releasing, and list your Helm repo on https://helm.hub.sh. Follow this issue for info about existing guidelines and upcoming improvements: https://github.com/helm/charts/issues/7800

@scottrigby scottrigby closed this Nov 27, 2019
@lucky-sideburn
Copy link
Author

https://hub.helm.sh/ :)

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants