Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

fixes example for importing grafana dashboards with the api #4437

Merged
merged 2 commits into from
Mar 30, 2018
Merged

fixes example for importing grafana dashboards with the api #4437

merged 2 commits into from
Mar 30, 2018

Conversation

sstarcher
Copy link
Collaborator

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2018
@sstarcher
Copy link
Collaborator Author

/assign @sameersbn

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2018
@sstarcher
Copy link
Collaborator Author

These 2 pull requests are pretty much duplicates - #4392

#4392 also changes it from wget to curl not sure why

@unguiculus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 26, 2018
@unguiculus
Copy link
Member

/assign

@sstarcher
Copy link
Collaborator Author

Nothing I changed should effect the e2e test. A helm install . works locally and no pods are failing.

@sameersbn sameersbn removed their assignment Mar 27, 2018
@unguiculus
Copy link
Member

Here' the reason: #4267

@unguiculus unguiculus mentioned this pull request Mar 27, 2018
Closed
@unguiculus
Copy link
Member

There's another PR that also fixes the URL in another place. See #4476.

I'd suggest you add this to your PR and we close the other one.

@unguiculus
Copy link
Member

Two more related PR: #4129, #4096

Let's consolidate this here.

This was referenced Mar 27, 2018
Closed
Closed
Closed
@sstarcher
Copy link
Collaborator Author

@unguiculus fixed the second location

@unguiculus unguiculus mentioned this pull request Mar 29, 2018
Closed
@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Mar 29, 2018
@sstarcher
Copy link
Collaborator Author

rebased and fixed merge conflict

@sstarcher
Copy link
Collaborator Author

@unguiculus had to resolve conflicts can I get another lgtm

@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sstarcher, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5bb9765 into helm:master Mar 30, 2018
rolanddb pushed a commit to Eneco/charts that referenced this pull request Apr 9, 2018
@sstarcher @rolanddb
fixes example for importing grafana dashboards with the api (helm#4437)
640766d 
* fixes example for importing grafana dashboards with the api

* adding app version
ichtar pushed a commit to Bestmile/charts that referenced this pull request May 15, 2018
@sstarcher
fixes example for importing grafana dashboards with the api (helm#4437)
3b2dbbb 
* fixes example for importing grafana dashboards with the api

* adding app version
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
@sstarcher
fixes example for importing grafana dashboards with the api (helm#4437)
97ddfbd 
* fixes example for importing grafana dashboards with the api

* adding app version

Signed-off-by: voron <av@arilot.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@unguiculus unguiculus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sstarcher @unguiculus @k8s-ci-robot @sameersbn