Align names between grafana service and job URL

[nseyvet]

What this PR does / why we need it:
Align service name and job url to inject datasources in Grafana.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Fixes issue #4485

Special notes for your reviewer:

[timstoop]

You also need to increase the version in Chart.yaml. That's required for all changes to a Chart.

[nseyvet]

@timestoop yes, saw that from build failure.

But the build still seems to fail. Can not reproduce problem.

[nseyvet]

What does this

Error validating data /home/circleci/project/stable/grafana/Chart.yaml with schema test/circle/yaml-schemas/Chart.yaml
	appVersion: Required field missing

mean? There are no appVersion in grafana anywhere.

[nseyvet]

Also added an "appVersion" field in Chart.yaml that points to version 4.6.3 of Grafana. But that should not have been required.

[timstoop]

It is required, there have been some changes in the build system recently that made some additional requirements to Charts. Not saying you caused the error, though, it's just that you're the first person working on this Chart to hit the problem with it :)

[timstoop]

/ok-to-test

[timstoop]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nseyvet, timstoop
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: prydonius

Assign the PR to them by writing /assign @prydonius in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[timstoop]

/assign @prydonius

[nseyvet]

The pull-charts-e2e tests failure is related to the configmap handling changes in later kubernetes version (1.9.4+) not the changes in this PR.
See grafana/grafana-docker#140

[sameersbn]

/retest

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[nseyvet]

Tried with 5.0.4 image which is not supposed to use chown anymore as per grafana/grafana-docker#140 . Still see the following errors in the logs: I0328 10:43:34.082] ---Logs from container grafana in pod grafana-7182-1-859c94c46d-x8sj2:--- I0328 10:43:34.445] chown: changing ownership of '/var/lib/grafana/dashboards/..data': Read-only file system I0328 10:43:34.445] chown: changing ownership of '/var/lib/grafana/dashboards/..2018_03_28_10_34_19.354854507': Read-only file system I0328 10:43:34.446] chown: changing ownership of '/var/lib/grafana/dashboards': Read-only file system
Will revert the change to 4.6.3.

[k8s-ci-robot]

@nseyvet: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-charts-e2e	29e5836	link	/test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[unguiculus]

Closing this in favor of #4437.