Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sphinx package requirements #1234

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Update sphinx package requirements #1234

merged 1 commit into from
Oct 11, 2023

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Oct 9, 2023 •
edited by ClaudiaComito
Loading

Due Diligence

  • General:
    • base branch must be main for new features, latest release branch (e.g. release/1.3.x) for bug fixes
    • title of the PR is suitable to appear in the Release Notes
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • documentation updated where needed

Description

Update the sphinx requirements to the latest versions fixing a build error in readthedocs.

Issue/s resolved: #1233

Changes proposed:

  • update sphinx requirements

Type of change

Documentation update

Memory requirements

n/a

Performance

n/a

Does this change modify the behaviour of other functions? If so, which?

no

@mtar mtar added the documentation Anything related to documentation label Oct 9, 2023
@ghost
Copy link

ghost commented Oct 9, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@mtar mtar linked an issue Oct 9, 2023 that may be closed by this pull request
[Bug]: rtd build process fails #1233
Closed
mrfh92
mrfh92 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@mrfh92 mrfh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not an expert regarding the RTD/sphinx-stuff, but as far as I can judge, the proposed changes will certainly not be able to cause damage; therefore, I recommend merging in the hope that this removes the "failed" flag from the RTD badge.

@ClaudiaComito ClaudiaComito merged commit 754fe1d into release/1.3.x Oct 11, 2023
40 checks passed
ClaudiaComito added a commit that referenced this pull request Oct 16, 2023
@ClaudiaComito @mtar
Update sphinx package requirements on main (#1245)
e56f569 
* Update requirements.txt (#1234)

* update version to dev

---------

Co-authored-by: Michael Tarnawa <m.tarnawa@fz-juelich.de>
@mtar mtar deleted the bugs/1233-_Bug_rtd_build_process_fails branch February 29, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrfh92 mrfh92 mrfh92 approved these changes

@ClaudiaComito ClaudiaComito Awaiting requested review from ClaudiaComito

Assignees
No one assigned
Labels
documentation Anything related to documentation merge queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: rtd build process fails
3 participants
@mtar @mrfh92 @ClaudiaComito