Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sphinx package requirements on main #1245

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

ClaudiaComito
Copy link
Contributor

Due Diligence

  • General:
    • base branch must be main for new features, latest release branch (e.g. release/1.3.x) for bug fixes
    • title of the PR is suitable to appear in the Release Notes
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • documentation updated where needed

Description

Issue/s resolved: #

Changes proposed:

Type of change

Documentation update

Memory requirements

NA

Performance

NA

Does this change modify the behaviour of other functions? If so, which?

no

@ClaudiaComito ClaudiaComito added the documentation Anything related to documentation label Oct 16, 2023
@ghost
Copy link

ghost commented Oct 16, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@github-actions
Copy link
Contributor

Thank you for the PR!

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #1245 (cfa1c47) into main (5beb254) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1245   +/-   ##
=======================================
  Coverage   91.75%   91.75%           
=======================================
  Files          77       77           
  Lines       11080    11080           
=======================================
  Hits        10166    10166           
  Misses        914      914           
Flag Coverage Δ
unit 91.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@mrfh92 mrfh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As fas as I can judge, the changes look fine.
Thanks for the work 👍

@ClaudiaComito ClaudiaComito merged commit e56f569 into main Oct 16, 2023
44 checks passed
@mtar mtar removed the PR talk label Nov 9, 2023
@mtar mtar deleted the bugs/merge-release-fixes-to-main branch February 29, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to documentation merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants