-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/783 api relational #792
Conversation
Codecov Report
@@ Coverage Diff @@
## master #792 +/- ##
=======================================
Coverage 95.28% 95.29%
=======================================
Files 64 64
Lines 8934 8944 +10
=======================================
+ Hits 8513 8523 +10
Misses 421 421
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not simply point to the existing functions? there is a bit of extra work going on here
i.e.
greater_equal = ge
greater_equal.__doc__ = ge.__doc__
You are right, that makes absolutely more sense indeed. Thanks for the feedback! I'll change it right away. |
Aliases for comparison functions in
heat.core.relational
This PR is motivated by the request in #774.
It is simply an extension of the current API in the corresponding module.
The following aliases have been implemented:
Issue/s resolved: #783
Changes proposed:
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no