is_compatible_with edge cases

[jules-ch]

Following on is_compatible_with, I found several edge cases.

Working with dimensionless with first argument :

>>> ureg.is_compatible_with(np.array([1, 2, 3, 4]), ureg.deg)
False

Expected True

>>> ureg.is_compatible_with(ureg.deg, 10.0)
True
>>> ureg.is_compatible_with(10.0, ureg.deg)
False

Expected True

With string as arguments:

>>>ureg.is_compatible_with("80 in", "35000 ft")
ValueError: Unit expression cannot have a scaling factor.
>>>ureg.is_compatible_with("in", "35000 ft")
ValueError: Unit expression cannot have a scaling factor.

For this error, we need to use parse_expression on Unit.is_compatible_with & Quantity.is_compatible_with instead of parse_units.

I've rewrited the function like so:

    def is_compatible_with(
        self, obj1, obj2, *contexts, **ctx_kwargs
    ):
        """ check if the other object is compatible

        Parameters
        ----------
        obj1, obj2
            The objects to check against each other. Treated as
            dimensionless if not a Quantity, Unit or str.
        *contexts : str or pint.Context
            Contexts to use in the transformation.
        **ctx_kwargs :
            Values for the Context/s

        Returns
        -------
        bool
        """
        if isinstance(obj1, (dict, bool, type(None))) or isinstance(obj2, (dict, bool, type(None))):
             raise TypeError("Type can't be casted to Quantity")

        if isinstance(obj1, (self.Quantity, self.Unit)):
            return obj1.is_compatible_with(obj2, *contexts, **ctx_kwargs)

        if isinstance(obj1, str):
            return self.parse_expression(obj1).is_compatible_with(
                obj2, *contexts, **ctx_kwargs
            )

        if isinstance(obj2, (self.Quantity, self.Unit, str)):
            return self.is_compatible_with(obj2, obj1, *contexts, **ctx_kwargs)
        else:
            return self.Quantity(obj1).is_compatible_with(obj2, *contexts, **ctx_kwargs)

Not sure if we should throw an error on types that can't be casted to Quantity or return simply False.

@keewis if you want to chime in

[hgrecco]

I think this is fixed, right @jules-ch ?

[jules-ch]

I need to rebase #1191