Fix #1190 Make is_compatible_with function work with dimensionless types & string parsing errors. #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jules-ch
changed the title
jules-ch
force-pushed
the
fix-1189-is-compatible-with-dimensionless-types
branch
from
3481378
to
684f783
Compare
jules-ch
changed the title
|
The code path for offset units is quite different. Maybe add a test for those, too? |
jules-ch
force-pushed
the
fix-1189-is-compatible-with-dimensionless-types
branch
3 times, most recently
from
92828b6
to
447b166
Compare
jules-ch
changed the title
keewis
reviewed
Oct 18, 2020
Comment on lines
+924
to
+930
| if isinstance(obj1, (dict, bool, type(None))) or isinstance( | ||
| obj2, (dict, bool, type(None)) | ||
| ): | ||
| raise TypeError("Type can't be casted to Quantity") | ||
|
|
There was a problem hiding this comment.
I'm not quite sure what the expected behavior should be: as per the docstring, everything which is not a Quantity, Unit or str is treated as dimensionless. Maybe it would be better to keep it that way?
Comment on lines
+937
to
+942
| if isinstance(obj2, (self.Quantity, self.Unit, str)): | ||
| return self.is_compatible_with(obj2, obj1, *contexts, **ctx_kwargs) | ||
| else: | ||
| return self.Quantity(obj1).is_compatible_with(obj2, *contexts, **ctx_kwargs) |
There was a problem hiding this comment.
obj2 possibly being a quantity / unit / str incompatible to dimensionless is a good point. Maybe something like this instead?
Suggested change
| if isinstance(obj2, (self.Quantity, self.Unit, str)): | |
| return self.is_compatible_with(obj2, obj1, *contexts, **ctx_kwargs) | |
| else: | |
| return self.Quantity(obj1).is_compatible_with(obj2, *contexts, **ctx_kwargs) | |
| if isinstance(obj2, (self.Quantity, self.Unit, str)): | |
| return self.is_compatible_with(obj2, obj1, *contexts, **ctx_kwargs) | |
| # neither obj1 or obj2 are Quantity, Unit or str objects so both are dimensionless | |
| return True |
I don't think we should try to make sure types unrelated to pint are compatible with each other, but we certainly could replace the return True with a ValueError.
jules-ch
force-pushed
the
fix-1189-is-compatible-with-dimensionless-types
branch
3 times, most recently
from
2ff644d
to
e90f50c
Compare
…types & string parsing errors. is_compatible_with was not consistent with dimensionless types when switching arguments. String processing was not allowing strings with any magnitude. - Updated registry.py managing dimensionless types & discarding types not managed by pint. - Updated unit.py using parse_expression instead of parse_units.
jules-ch
force-pushed
the
fix-1189-is-compatible-with-dimensionless-types
branch
from
e90f50c
to
154463e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black -t py36 . && isort -rc . && flake8with no errorsDocumented in docs/ as appropriateMake is_compatible_with function with dimensionless types & string parsing errors.
is_compatible_with was not consistent with dimensionless types when switching arguments.
String processing was not allowing strings with any magnitude.