ACT-482: Fix error when updating indicator data #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the Purpose?
Fix JSON decoding error that occurs when trying to update an Indicator that has existing disaggregations.
What was the approach?
Add a
JSON.stringfyto the data being passed to the backend, this will allow the full object to be sent back and then decoded successfully by the backend. The previous implementation returned a representation of the object that could not be decoded in the backend.Are there any concerns to addressed further before or after merging this PR?
None
Mentions?
@odenypeter @andrewtpham @TAnas0
Issue(s) affected?
#482
#455