Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a configurable max timeout for outgoing predicate payload requests #642

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

rafaelcr
Copy link
Collaborator

@rafaelcr rafaelcr commented Sep 10, 2024

This PR adds a new (optional) entry to the config .toml file so outgoing predicate payload HTTP POST requests can have a configurable timeout that will cancel the request if hit.

[predicates]
payload_http_request_timeout_ms = 10000

This new setting is useful to public-facing chainhook instances that may run into unresponsive 3rd party servers that may take forever to respond to a payload request.

Fixes #643

@rafaelcr rafaelcr changed the base branch from main to develop October 9, 2024 15:59
@rafaelcr rafaelcr changed the title fix: add a max timeout for outgoing requests fix: add a configurable max timeout for outgoing predicate payload requests Oct 9, 2024
@rafaelcr rafaelcr requested a review from csgui October 9, 2024 16:38
Copy link
Contributor

@csgui csgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments and changes as suggestion.

@rafaelcr rafaelcr requested a review from csgui October 10, 2024 16:35
@rafaelcr rafaelcr had a problem deploying to Development-mainnet October 10, 2024 16:54 — with GitHub Actions Failure
@rafaelcr rafaelcr had a problem deploying to Development-testnet October 10, 2024 16:54 — with GitHub Actions Failure
Copy link
Contributor

@csgui csgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@rafaelcr rafaelcr merged commit 6c1dfa9 into develop Oct 10, 2024
10 of 12 checks passed
@rafaelcr rafaelcr deleted the fix/timeout branch October 10, 2024 17:11
github-actions bot pushed a commit that referenced this pull request Oct 25, 2024
## [1.9.0-stacks-signers.1](v1.8.0...v1.9.0-stacks-signers.1) (2024-10-25)

### Features

* add various new nakamoto block fields to `/new_block` ingestion and `StacksPayload` ([#659](#659)) ([f48cda5](f48cda5))
* include recovered signer pubkeys in new block payload ([#662](#662)) ([b5ad4ba](b5ad4ba))
* include signer messages in Stacks predicate payloads ([#656](#656)) ([aee14bc](aee14bc))
* parse `/stackerdb_chunks` Stacks node event ([#653](#653)) ([e44d84a](e44d84a))
* store signer messages in local sqlite database ([#664](#664)) ([d12acd9](d12acd9))
* support tenure-height in block messages ([#661](#661)) ([99e5a61](99e5a61))
* **ts-client:** add persisted predicates and periodic health check ([#658](#658)) ([535226a](535226a))
* **ts-client:** add signer messages to stacks payloads ([#657](#657)) ([ff66bb2](ff66bb2))

### Bug Fixes

* add a configurable max timeout for outgoing predicate payload requests ([#642](#642)) ([6c1dfa9](6c1dfa9)), closes [#643](#643)
* increase stacks event server body size limit to 500MB ([#660](#660)) ([21234c9](21234c9))
* return 500 status code to Stacks node when event ingestion fails ([#648](#648)) ([63c753c](63c753c)), closes [#646](#646)
* signer pubkey calculation ([#665](#665)) ([cc93873](cc93873))
* update SignerMessage deserializing ([#663](#663)) ([71364c1](71364c1))
* validate ts client predicates before registering ([#639](#639)) ([2d08f72](2d08f72))
Copy link

🎉 This PR is included in version 1.9.0-stacks-signers.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

add a configurable max timeout for predicate requests
2 participants