feat: include recovered signer pubkeys in new block payload #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zone117x
commented
Oct 24, 2024
Comment on lines
515
to
526
| signer_public_keys: match (signer_sig_hash, &block.signer_signature) { | ||
| (Some(signer_sig_hash), Some(signatures)) => { | ||
| Some(signatures.iter().map(|sig_hex| { | ||
| let sig_msg = clarity::util::secp256k1::MessageSignature::from_hex(sig_hex) | ||
| .expect("unable to parse signer signature message"); | ||
| let pubkey = get_signer_pubkey_from_message_hash(&signer_sig_hash, &sig_msg) | ||
| .expect("unable to recover signer sig pubkey"); | ||
| format!("0x{}", hex::encode(pubkey)) | ||
| }).collect()) | ||
| } | ||
| _ => None, | ||
| }, |
There was a problem hiding this comment.
@rafaelcr any suggestions on how to add a test for this? I have a sample /new_block message and the expected pubkeys to use as a test vector, but not sure where/how to set that up.
There was a problem hiding this comment.
That's a good question, haven't quite figured out how to properly do tests yet, we should put a pin on this and I'll write some tests once we have the entire signers feature wired up and working
zone117x
had a problem deploying
to
Development-mainnet
GitHub Actions
Error
zone117x
had a problem deploying
to
Development-testnet
GitHub Actions
Error
rafaelcr
reviewed
Oct 24, 2024
Comment on lines
515
to
526
| signer_public_keys: match (signer_sig_hash, &block.signer_signature) { | ||
| (Some(signer_sig_hash), Some(signatures)) => { | ||
| Some(signatures.iter().map(|sig_hex| { | ||
| let sig_msg = clarity::util::secp256k1::MessageSignature::from_hex(sig_hex) | ||
| .expect("unable to parse signer signature message"); | ||
| let pubkey = get_signer_pubkey_from_message_hash(&signer_sig_hash, &sig_msg) | ||
| .expect("unable to recover signer sig pubkey"); | ||
| format!("0x{}", hex::encode(pubkey)) | ||
| }).collect()) | ||
| } | ||
| _ => None, | ||
| }, |
There was a problem hiding this comment.
That's a good question, haven't quite figured out how to properly do tests yet, we should put a pin on this and I'll write some tests once we have the entire signers feature wired up and working
rafaelcr
approved these changes
Oct 24, 2024
zone117x
had a problem deploying
to
Development-mainnet
GitHub Actions
Failure
zone117x
had a problem deploying
to
Development-testnet
GitHub Actions
Failure
github-actions bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
## [1.9.0-stacks-signers.1](v1.8.0...v1.9.0-stacks-signers.1) (2024-10-25) ### Features * add various new nakamoto block fields to `/new_block` ingestion and `StacksPayload` ([#659](#659)) ([f48cda5](f48cda5)) * include recovered signer pubkeys in new block payload ([#662](#662)) ([b5ad4ba](b5ad4ba)) * include signer messages in Stacks predicate payloads ([#656](#656)) ([aee14bc](aee14bc)) * parse `/stackerdb_chunks` Stacks node event ([#653](#653)) ([e44d84a](e44d84a)) * store signer messages in local sqlite database ([#664](#664)) ([d12acd9](d12acd9)) * support tenure-height in block messages ([#661](#661)) ([99e5a61](99e5a61)) * **ts-client:** add persisted predicates and periodic health check ([#658](#658)) ([535226a](535226a)) * **ts-client:** add signer messages to stacks payloads ([#657](#657)) ([ff66bb2](ff66bb2)) ### Bug Fixes * add a configurable max timeout for outgoing predicate payload requests ([#642](#642)) ([6c1dfa9](6c1dfa9)), closes [#643](#643) * increase stacks event server body size limit to 500MB ([#660](#660)) ([21234c9](21234c9)) * return 500 status code to Stacks node when event ingestion fails ([#648](#648)) ([63c753c](63c753c)), closes [#646](#646) * signer pubkey calculation ([#665](#665)) ([cc93873](cc93873)) * update SignerMessage deserializing ([#663](#663)) ([71364c1](71364c1)) * validate ts client predicates before registering ([#639](#639)) ([2d08f72](2d08f72))
|
🎉 This PR is included in version 1.9.0-stacks-signers.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.