Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New chat TODO list #1298

Closed
34 of 44 tasks
drunkplato opened this issue Mar 29, 2023 · 6 comments · Fixed by #1326 or #1341
Closed
34 of 44 tasks

New chat TODO list #1298

drunkplato opened this issue Mar 29, 2023 · 6 comments · Fixed by #1326 or #1341
Assignees
Labels
1:high-priority Needs to be done as soon as possible chat Realm chat or chat db related
Milestone

Comments

@drunkplato
Copy link
Contributor

drunkplato commented Mar 29, 2023

Bug list

Animation restructure

  • Fix initial animation expansion on Inbox @drunkplato - Chat log scroll fix #1305
  • Private links (Ex. a Realm PR) attempt to render but don't - glitchy and leaves a bunch of empty space between messages.

New features - after stable

After chat launch

  • Bundle standalone chat app 
@drunkplato drunkplato added 1:high-priority Needs to be done as soon as possible chat Realm chat or chat db related labels Mar 29, 2023
@drunkplato drunkplato added this to the Chat milestone Mar 29, 2023
@Tenari
Copy link
Contributor

Tenari commented Mar 29, 2023

#1299

@Tenari
Copy link
Contributor

Tenari commented Mar 29, 2023

see the following commits:

Tenari added a commit that referenced this issue Mar 31, 2023
Tenari added a commit that referenced this issue Mar 31, 2023
Tenari added a commit that referenced this issue Mar 31, 2023
#1298 Update the sentAt time via an interval similar to the clock
@gdbroman gdbroman linked a pull request Apr 3, 2023 that will close this issue
Tenari added a commit that referenced this issue Apr 3, 2023
#1298 only match at beginning of input or after newline
@gdbroman gdbroman linked a pull request Apr 4, 2023 that will close this issue
Tenari added a commit that referenced this issue Apr 4, 2023
Tenari added a commit that referenced this issue Apr 4, 2023
#1298 fix delete group chat ui crash, re-do the growing chat input
@gdbroman gdbroman linked a pull request Apr 4, 2023 that will close this issue
@gdbroman
Copy link
Contributor

gdbroman commented Apr 5, 2023

Double-send bug

When I send a message in the Holium group chat, a duplicate comes back, and it causes an infinite render loop.

Below is a screenshot with logged messages from useChatStore, showing that the latest two messages are duplicates, so it's not a rendering bug.

When reacting, the emoji count doubles to 2 as well.

All of this only happens in the Holium group chat.

When I click out of the chat and re-enter, all duplications are gone.

CleanShot 2023-04-05 at 11 23 30@2x

@ajlamarc
Copy link
Contributor

ajlamarc commented Apr 5, 2023

image

  • Add proper padding for multi-line messages - should be comparable to a single-line text
    image
  • Adding many lines and then deleting them, resize down doesn't happen until less than 1 line left.

@Tenari
Copy link
Contributor

Tenari commented Apr 5, 2023

Double-send bug

When I send a message in the Holium group chat, a duplicate comes back, and it causes an infinite render loop.

Below is a screenshot with logged messages from useChatStore, showing that the latest two messages are duplicates, so it's not a rendering bug.

When reacting, the emoji count doubles to 2 as well.

All of this only happens in the Holium group chat.

When I click out of the chat and re-enter, all duplications are gone.

CleanShot 2023-04-05 at 11 23 30@2x

this must be a rendering bug. the agent can't create two messages with the same id, since they would just overwrite in the mop
also I can't reproduce this at all, so I'm not sure how to debug this further.

@Tenari
Copy link
Contributor

Tenari commented Apr 5, 2023

image

  • Add proper padding for multi-line messages - should be comparable to a single-line text
    image
  • Adding many lines and then deleting them, resize down doesn't happen until less than 1 line left.

these are handled as a part of #1327

@gdbroman gdbroman reopened this Apr 6, 2023
Tenari added a commit that referenced this issue Apr 6, 2023
drunkplato added a commit that referenced this issue Apr 6, 2023
#1298 %status should be sent when the expiresDuration is changed
@gdbroman gdbroman linked a pull request Apr 6, 2023 that will close this issue
Tenari added a commit that referenced this issue Apr 6, 2023
#1298 clicking on an image shows it in a lightbox
drunkplato added a commit that referenced this issue Apr 7, 2023
#1298 shrink chat input after send, enable right click save image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment