Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1298 fix delete group chat ui crash, re-do the growing chat input #1324

Merged
merged 2 commits into from
Apr 4, 2023
Merged

#1298 fix delete group chat ui crash, re-do the growing chat input #1324

merged 2 commits into from
Apr 4, 2023

Conversation

Tenari
Copy link
Contributor

@Tenari Tenari commented Apr 4, 2023 •
edited
Loading

No description provided.

@Tenari Tenari requested review from drunkplato and gdbroman April 4, 2023 16:26
@Tenari Tenari changed the title #1298 fix delete group chat ui crash, re-do the grwoing chat input to… #1298 fix delete group chat ui crash, re-do the growing chat input Apr 4, 2023
gdbroman
gdbroman approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@gdbroman gdbroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be sweet to keep some padding over and under the expanded input

CleanShot 2023-04-04 at 18 46 24@2x

@Tenari
Copy link
Contributor Author

Tenari commented Apr 4, 2023

there's 2px above and below, or there should be... maybe it's just 4px under

@Tenari Tenari merged commit 0638708 into master Apr 4, 2023
@Tenari Tenari deleted the del-crash_and_input-grow-better branch April 4, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdbroman gdbroman gdbroman approved these changes

@drunkplato drunkplato Awaiting requested review from drunkplato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tenari @gdbroman