Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Tabulator to 4.9.3 #3094

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Downgrade Tabulator to 4.9.3 #3094

merged 2 commits into from
Jan 12, 2022

Conversation

philippjfr
Copy link
Member

The upgrade to 5.0.x was premature since at least as of right now the performance is significantly worse.

Hopefully these issues will eventually be addressed and we'll be able to upgrade again.

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #3094 (d3f6b23) into master (afd555a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3094      +/-   ##
==========================================
- Coverage   83.46%   83.46%   -0.01%     
==========================================
  Files         190      190              
  Lines       25206    25212       +6     
==========================================
+ Hits        21038    21042       +4     
- Misses       4168     4170       +2     
Impacted Files Coverage Δ
panel/models/tabulator.py 98.76% <100.00%> (+0.13%) ⬆️
panel/io/reload.py 69.23% <0.00%> (-2.20%) ⬇️
panel/tests/command/test_serve.py 83.54% <0.00%> (-1.46%) ⬇️
panel/pane/idom.py 27.40% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afd555a...d3f6b23. Read the comment docs.

@philippjfr philippjfr merged commit b6f32ac into master Jan 12, 2022
@philippjfr philippjfr deleted the downgrade_tabulator branch January 12, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant