Improve handling of ReactiveHTML cleanup #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2974 +/- ##
==========================================
- Coverage 83.12% 82.90% -0.22%
==========================================
Files 190 190
Lines 24953 24472 -481
==========================================
- Hits 20741 20289 -452
+ Misses 4212 4183 -29
Continue to review full report at Codecov.
|
philippjfr
added a commit
that referenced
this pull request
Dec 7, 2021
This was referenced Dec 7, 2021
Merged
philippjfr
added a commit
that referenced
this pull request
Dec 8, 2021
* Always load imported bokeh extensions (#2957) * Do not run ace import on initialization (#2959) * Fix regression rendering HoloViews plotly backend (#2961) * Fix regression rendering HoloViews plotly backend * Fix flake * Improve handling of ReactiveHTML cleanup (#2974) * Ensure empty Str has same height as non-empty (#2981) * Ensure Tabulator supports grouping on numeric columns (#2987) * Fix Tabulator with multi-index and pagination (#2989) * Fix Tabulator with multi-index and pagination * Pin Django * Allow index as column name in table widgets (#2990) * Allow index as column name in table widgets * Handle unnamed indexes * Update CHANGELOG * Cleanup * Fix cleanup of children on ReactiveHTML (#2993) * Ensure TemplateActions component does not have height (#2997) * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that ReactiveHTML children are always cleaned up correctly.