Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure TemplateActions component does not have height #2997

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

philippjfr
Copy link
Member

The TemplateActions component added to all templates had a margin and therefore took up unnecessary height.

@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label Dec 8, 2021
@philippjfr philippjfr added this to the v0.12.6 milestone Dec 8, 2021
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #2997 (eacb0c3) into master (469a629) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2997      +/-   ##
==========================================
- Coverage   83.25%   83.24%   -0.02%     
==========================================
  Files         190      190              
  Lines       25023    25024       +1     
==========================================
- Hits        20834    20832       -2     
- Misses       4189     4192       +3     
Impacted Files Coverage Δ
panel/template/base.py 78.76% <100.00%> (+0.04%) ⬆️
panel/io/reload.py 69.23% <0.00%> (-2.20%) ⬇️
panel/models/reactive_html.py 79.57% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 469a629...eacb0c3. Read the comment docs.

@philippjfr philippjfr merged commit 6aa49e2 into master Dec 8, 2021
@philippjfr philippjfr deleted the template_actions_height branch December 8, 2021 17:04
@philippjfr philippjfr mentioned this pull request Dec 8, 2021
philippjfr added a commit that referenced this pull request Dec 8, 2021
* Always load imported bokeh extensions (#2957)

* Do not run ace import on initialization (#2959)

* Fix regression rendering HoloViews plotly backend (#2961)

* Fix regression rendering HoloViews plotly backend

* Fix flake

* Improve handling of ReactiveHTML cleanup (#2974)

* Ensure empty Str has same height as non-empty (#2981)

* Ensure Tabulator supports grouping on numeric columns (#2987)

* Fix Tabulator with multi-index and pagination (#2989)

* Fix Tabulator with multi-index and pagination

* Pin Django

* Allow index as column name in table widgets (#2990)

* Allow index as column name in table widgets

* Handle unnamed indexes

* Update CHANGELOG

* Cleanup

* Fix cleanup of children on ReactiveHTML (#2993)

* Ensure TemplateActions component does not have height (#2997)

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant