Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal removal of old API usage #372

Merged
merged 5 commits into from
Jan 23, 2020
Merged

Internal removal of old API usage #372

merged 5 commits into from
Jan 23, 2020

Conversation

jlstevens
Copy link
Contributor

Spotted while working on holoviz/holoviews#4201.

@coveralls
Copy link

coveralls commented Jan 23, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 76.24% when pulling 1e974fd on new_api_fix into 472f9af on master.

@jlstevens jlstevens changed the title Fixed instance of old API usage in instance bothmethod Internal removal of old API usage Jan 23, 2020
@jlstevens
Copy link
Contributor Author

Unit tests are now passing. I'll now toggle the _disable_stubs flag globally and I think it is ready to merge.

@jbednar jbednar merged commit 4e3ddf4 into master Jan 23, 2020
@jbednar jbednar deleted the new_api_fix branch January 23, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbednar jbednar jbednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlstevens @coveralls @jbednar