-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning when using methods outside param namespace #4201
Conversation
Seems like we hadn't done much of a pass on this update before (as I had thought). There is a lot that needs updating (e.g see the two PRs referenced above) and
I'll have to go through the unit test files one by one to weed out old usage... @philippjfr As this will end up as a big PR that touches a lot of files, I hope there aren't going to be any big merge conflicts! |
Not worried tbh, if there's merge conflicts so be it. |
@philippjfr I've fixed the datashader unit test as requested. The other unit test failures need fixes elsewhere that are not related to this PR. If you are happy with the changes I would appreciate if you could review/merge. |
1959fad
to
2c79b6a
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Currently toggling on warnings but once they are all fixed I think it might be worth raising errors instead. My plan is to use travis to find out where things need updating.