Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning when using methods outside param namespace #4201

Merged
merged 14 commits into from
Jan 24, 2020

Conversation

jlstevens
Copy link
Contributor

Currently toggling on warnings but once they are all fixed I think it might be worth raising errors instead. My plan is to use travis to find out where things need updating.

@jlstevens
Copy link
Contributor Author

Seems like we hadn't done much of a pass on this update before (as I had thought). There is a lot that needs updating (e.g see the two PRs referenced above) and PlotSelector in particular is a pain (possibly fixed by aliasing .params to .param there). Then there are lots of messages like this:

.WARNING:param.CurvePlot214092: The Parameterized instance has instance parameters created using new-style param APIs, which are incompatible with .params. Use the new more explicit APIs on the .param accessor to query parameter instances.To query all parameter instances use .param.objects with the option to return either class or instance parameter objects. Alternatively use .param[name] indexing to access a specific parameter object by name.

I'll have to go through the unit test files one by one to weed out old usage...

@philippjfr As this will end up as a big PR that touches a lot of files, I hope there aren't going to be any big merge conflicts!

@philippjfr
Copy link
Member

As this will end up as a big PR that touches a lot of files, I hope there aren't going to be any big merge conflicts!

Not worried tbh, if there's merge conflicts so be it.

@jlstevens
Copy link
Contributor Author

@philippjfr I've fixed the datashader unit test as requested. The other unit test failures need fixes elsewhere that are not related to this PR. If you are happy with the changes I would appreciate if you could review/merge.

@philippjfr philippjfr force-pushed the param_namespace_warning branch from 1959fad to 2c79b6a Compare January 23, 2020 23:46
@philippjfr philippjfr merged commit c85b1db into master Jan 24, 2020
@philippjfr philippjfr deleted the param_namespace_warning branch April 25, 2022 14:42
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants