-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report missing entities/areas instead of failing to match in Assist #107151
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
73dc81c
to
e857103
Compare
@synesthesiam should we make the error messages a bit more friendly, more user-readable, while we're at it? Something like "Sorry, I am not aware of any area named dungeon" or "Sorry, I am not aware of any entity called floodlights"? |
* upstream/dev: (2071 commits) Set zwave_js voltage sensor suggested precision (home-assistant#107116) Bump bluetooth-adapters to 0.17.0 (home-assistant#107195) Disable IPv6 in the opower integration to fix AEP utilities (home-assistant#107203) Fix conversation snapshots (home-assistant#107196) Report missing entities/areas instead of failing to match in Assist (home-assistant#107151) Bump to PyTado 0.17.3 (home-assistant#107181) Fix switch states in AVM FRITZ!Box Tools (home-assistant#107183) Fix tplink overloading power strips (home-assistant#104208) Update sensorpush-ble library to 1.6.1 (home-assistant#107168) Bump aiohomekit to 3.1.2 (home-assistant#107177) Introduce base entity in streamlabs water (home-assistant#107095) Clean up outdated entity replacement logic in Guardian (home-assistant#107160) Add conversation_id parameter to conversation.process service (home-assistant#106078) Pass aiohttp clientsession to tedee integration (home-assistant#107089) Update Home Assistant base image to 2024.01.0 - Python 3.12 (home-assistant#107175) Remove precision in streamlabs water (home-assistant#107096) Pass down language to hassil (home-assistant#106490) Use snapshots in Glances sensor tests (home-assistant#107159) Cache homekit_controller supported features (home-assistant#106702) Migrate AVM FRITZ!Box Call monitor to has entity name (home-assistant#99752) ...
Yes, we need the errors to say that something couldn't be found, not that it isn't there. I was thinking something like "Sorry, I couldn't find an area named X". |
Correct me if i'm wrong: there are 2 possible reasons for which an entity can't be handled - either it doesn't exist with that name/alias or it's not exposed. For areas, the only possible reason is that it doesn't exist with that name/alias.
For me personally, it seems like "couldn't find" (traditionally, in UIs) hints more towards inexistence and less towards lack of exposure, whereas "I am not aware" is vague enough to hint to both. Shall we ask the Discord community? Do you want to take an executive decision? :D |
I do like the "not aware" terminology" better than "couldn't find". This question gets trickier with domain and device class constraints. A failure with "turn on lights in the kitchen" could be a missing area, no lights in the kitchen, or just no exposed lights. I think for this case, we may want to have an extra definitive error: "there are no lights in the kitchen". |
Breaking change
Proposed change
This PR:
Hassil, the intent matching library behind Assist, will report an intent match failure if the names of entities or areas are not what it expects by default ("Sorry, I couldn't understand that").
This PR uses a new feature of hassil 1.5.2 to produce more useful error messages. If a match fails, hassil is run again with "unmatched entities" enabled (slower), and the "best" match is used to determine the error message.
Choosing the "best" match is tricky. For example, "turn on the overhead light" could be interpreted as:
turn on the <name>
with name = "overhead light"turn on the <area> <name>
with area = "overhead", name = "light"In fact, there are many more possible matches, some including "the" in the entity or area name, etc.
The "best" match is the one with:
<name>
or<area>
will be preferred to<area> <name>
<name>
Only errors relating to unmatched
<name>
and<area>
slots are currently supported. Errors for unmatched domains and device classes require more changes, and will be done in a future PR.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: