Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sensorpush-ble library to 1.6.1 #107168

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Update sensorpush-ble library to 1.6.1 #107168

merged 5 commits into from
Jan 4, 2024

Conversation

ashleigh-hopkins
Copy link
Contributor

@ashleigh-hopkins ashleigh-hopkins commented Jan 4, 2024 •
edited by bdraco
Loading

Proposed change

Update sensorpush-ble to version 1.6.1

This version adds support for the SensorPush HT1

changelog: Bluetooth-Devices/sensorpush-ble@v1.5.5...v1.6.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • [] The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation: home-assistant/home-assistant.io#30646

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

home-assistant[bot]
home-assistant bot previously requested changes Jan 4, 2024
View reviewed changes
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ashleigh-hopkins

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Jan 4, 2024

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (sensorpush) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sensorpush can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sensorpush Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@ashleigh-hopkins ashleigh-hopkins mentioned this pull request Jan 4, 2024
Merged
8 tasks
@ashleigh-hopkins ashleigh-hopkins changed the title Sensorpush dependency update Update sensorpush-ble library to 1.6.1 Jan 4, 2024
@bdraco
Copy link
Member

bdraco commented Jan 4, 2024

You'll likely need to run python3 -m script.gen_requirements_all

@bdraco
Copy link
Member

bdraco commented Jan 4, 2024

CI started

bdraco
bdraco approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashleigh-hopkins

@bdraco bdraco marked this pull request as ready for review January 4, 2024 21:54
@bdraco
Copy link
Member

bdraco commented Jan 4, 2024

tested with my existing device (not an HT1) and it didn't break so all good there.

@bdraco bdraco merged commit 0ff5ccb into home-assistant:dev Jan 4, 2024
53 checks passed
@ashleigh-hopkins ashleigh-hopkins deleted the sensorpush-dependency-update branch January 4, 2024 23:42
raman325 added a commit to raman325/home-assistant that referenced this pull request Jan 5, 2024
@raman325
Merge remote-tracking branch 'upstream/dev' into device
8eea524 
* upstream/dev: (2071 commits)
  Set zwave_js voltage sensor suggested precision (home-assistant#107116)
  Bump bluetooth-adapters to 0.17.0 (home-assistant#107195)
  Disable IPv6 in the opower integration to fix AEP utilities (home-assistant#107203)
  Fix conversation snapshots (home-assistant#107196)
  Report missing entities/areas instead of failing to match in Assist (home-assistant#107151)
  Bump to PyTado 0.17.3 (home-assistant#107181)
  Fix switch states in AVM FRITZ!Box Tools (home-assistant#107183)
  Fix tplink overloading power strips (home-assistant#104208)
  Update sensorpush-ble library to 1.6.1 (home-assistant#107168)
  Bump aiohomekit to 3.1.2 (home-assistant#107177)
  Introduce base entity in streamlabs water (home-assistant#107095)
  Clean up outdated entity replacement logic in Guardian (home-assistant#107160)
  Add conversation_id parameter to conversation.process service (home-assistant#106078)
  Pass aiohttp clientsession to tedee integration (home-assistant#107089)
  Update Home Assistant base image to 2024.01.0 - Python 3.12 (home-assistant#107175)
  Remove precision in streamlabs water (home-assistant#107096)
  Pass down language to hassil (home-assistant#106490)
  Use snapshots in Glances sensor tests (home-assistant#107159)
  Cache homekit_controller supported features (home-assistant#106702)
  Migrate AVM FRITZ!Box Call monitor to has entity name (home-assistant#99752)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

@home-assistant home-assistant[bot] Awaiting requested review from home-assistant[bot]

Assignees

@bdraco bdraco

Labels
cla-signed dependency integration: sensorpush new-feature Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashleigh-hopkins @bdraco