Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uv instead of pip in development env #113517

Merged
merged 24 commits into from
May 21, 2024
Merged

Use uv instead of pip in development env #113517

merged 24 commits into from
May 21, 2024

Conversation

edenhaus
Copy link
Contributor

Breaking change

Proposed change

Replace pip by uv in the development environment including all scripts and dev container
Split from #112496

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed small-pr PRs with less than 30 lines. labels Mar 15, 2024
@edenhaus edenhaus force-pushed the edenhaus-uv-dev-env branch from 08ab939 to e406dca Compare March 15, 2024 13:59
script/setup Outdated Show resolved Hide resolved
@autinerd
Copy link
Contributor

autinerd commented May 1, 2024

I tested it now on a fresh live system and it works without problems regardless whether uv is already installed or not. For me it looks good to go :) (I can't judge about the Docker part, however)

@edenhaus
Copy link
Contributor Author

Tested it codespaces/dev container and also locally on arch. Feel free to test it in different dev envs :)

@edenhaus edenhaus marked this pull request as ready for review May 20, 2024 13:38
@edenhaus edenhaus requested a review from a team as a code owner May 20, 2024 13:38
@edenhaus edenhaus requested a review from frenck May 20, 2024 13:39
@edenhaus edenhaus added the smash Indicator this PR is close to finish for merging or closing label May 20, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @edenhaus 👍

../Frenck

@frenck frenck merged commit 5e3483a into dev May 21, 2024
38 checks passed
@frenck frenck deleted the edenhaus-uv-dev-env branch May 21, 2024 07:56
@farmio
Copy link
Contributor

farmio commented May 21, 2024

I do get

home-assistant/script/run-in-env.sh: line 16: VIRTUAL_ENV: unbound variable

now when pre-commit runs mypy and pylint from GitHub Desktop App. Using pre-commit run from terminal works fine 🙃

@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants