-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pip jemalloc config from dockerfile #115206
Remove pip jemalloc config from dockerfile #115206
Conversation
home-assistant#85738 changed the docker build so that pip would use jemalloc. uv is already using jemalloc, so this configuration isn't needed anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Test image pipeline succeded in https://github.com/home-assistant/core/actions/runs/8600787317 |
The test failure seems unrelated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @konstin 👍
Breaking change
Proposed change
#85738 changed the docker build so that pip would use jemalloc. uv is already using jemalloc, so this configuration isn't needed anymore. This change only affects the dependency installation process inside the docker build.
Type of change
Additional information
Checklist
python:3.12-alpine
as base image.ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: