Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pip jemalloc config from dockerfile #115206

Merged

Conversation

konstin
Copy link
Contributor

@konstin konstin commented Apr 8, 2024

Breaking change

Proposed change

#85738 changed the docker build so that pip would use jemalloc. uv is already using jemalloc, so this configuration isn't needed anymore. This change only affects the dependency installation process inside the docker build.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally. _I can build it locally with python:3.12-alpine as base image.
  • Local tests pass. Your PR cannot be merged unless tests pass How do i run the tests on a docker container?
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works. I've built the container but i'm not sure how to run proper tests on this

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

home-assistant#85738 changed the docker build so that pip would use jemalloc. uv is already using jemalloc, so this configuration isn't needed anymore
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @konstin

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot added cla-needed code-quality small-pr PRs with less than 30 lines. labels Apr 8, 2024
@home-assistant home-assistant bot marked this pull request as draft April 8, 2024 13:07
@home-assistant
Copy link

home-assistant bot commented Apr 8, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@konstin konstin marked this pull request as ready for review April 8, 2024 13:16
@home-assistant home-assistant bot dismissed their stale review April 8, 2024 13:16

Stale

@konstin konstin requested a review from a team as a code owner April 8, 2024 13:29
@edenhaus
Copy link
Contributor

edenhaus commented Apr 8, 2024

Test image pipeline succeded in https://github.com/home-assistant/core/actions/runs/8600787317

@konstin
Copy link
Contributor Author

konstin commented Apr 9, 2024

The test failure seems unrelated

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @konstin 👍

@edenhaus edenhaus merged commit cad4c3c into home-assistant:dev Apr 9, 2024
33 of 34 checks passed
@konstin konstin deleted the konsti/remove-pip-ld-preload-config branch April 9, 2024 13:12
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants