New fan platform airscape

[quielb]

Description:

Adding Airscape platform for the fan component to control Airscape Whole House Fans

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10452

Example entry for configuration.yaml (if applicable):

fan:
  - platform: airscape
    name: "Whole House Fan"
    host: "192.168.10.100"

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[quielb]

black formatting conflicts with pycodestyle line length checks:

Black wants to change the following (only one example, there are several)

-        except (
-            airscape.exceptions.ConnectionError,
-            airscape.exceptions.Timeout
-        ):
+        except (airscape.exceptions.ConnectionError, airscape.exceptions.Timeout):

But if I let black do that, then pycodestyle complains about line length:

fan.py:15:80: E501 line too long (80 > 79 characters)
fan.py:45:80: E501 line too long (83 > 79 characters)
fan.py:118:80: E501 line too long (82 > 79 characters)
fan.py:125:80: E501 line too long (82 > 79 characters)
fan.py:132:80: E501 line too long (82 > 79 characters)
fan.py:140:80: E501 line too long (82 > 79 characters)
fan.py:159:80: E501 line too long (82 > 79 characters)
fan.py:169:80: E501 line too long (82 > 79 characters)

which one wins?

[frenck]

We only consider and use Black for code formatting and use the 88 char line length that Black uses by default.

[quielb]

Not sure how I missed the pylint errors in my local tox run but I did. Though it might be a rebase issue so I rebased to dev latest branch ( was still on .99 level now at .100 ) and still get the pylint errors with tox -e pylint. Not sure what to do with them. since ,my changes aren't related to pylint errors. Not sure how CI tests are passing for any PR at this point.

Also not sure why code coverage is complaining either. I updated .coveragerc and can't do unit tests because communicates with external device. So there won't be any coverage for this diff.

[MartinHjelmare]

Only speeds available in the base fan component are allowed in the speed list. Try to map as best possible between those and the device speed settings.

[quielb]

home-assistant/architecture#127

[MartinHjelmare]

Do you want to wait with continuing here until the architecture issue is resolved? If so please close this PR while waiting.

[quielb]

I was hoping to restart the conversation in the architecture repo. But it doesn't seem like anyone has the bandwidth to deal with this right now. I guess the best thing to do is close this and just move my platform over to a custom component until the architecture issue gets resolved.

[MartinHjelmare]

Try rebasing on latest dev branch to let the build pass without non related errors.

[quielb]

Try rebasing on latest dev branch to let the build pass without non related errors.

I rebased to latest dev branch and I am still get non related errors.

[quielb]

Try rebasing on latest dev branch to let the build pass without non related errors.

I rebased to latest dev branch and I am still get non related errors.

Looking deeper into my tox -e pylint errors I'm seeing import problems. There is something wrong with my venv. I tried rebuilding it, but I'm still having issues. I'm going to push the changes that I have and see what happens with the CI test pipeline while I try to resolve the other issues in my venv