Update AddHoneycomb with settings instance to use Action<>

[MikeGoldsmith]

Fixes #17.

Updates the serviceCollection.AddHoneycomb programatic overload to take an Action<HoneycombApiSettings>.

[ericsampson]

Out of curiosity, is there a precedence/convention of not supporting both options (class and Action) ? I've seen different libraries choose different combinations of IConfiguration, LibSettings, and Action<LibSettings>configureLibSettings

[MikeGoldsmith]

Out of curiosity, is there a precedence/convention of not supporting both options (class and Action) ? I've seen different libraries choose different combinations of IConfiguration, LibSettings, and Action<LibSettings>configureLibSettings

There isn't a convention of preferring one type of parameter vs another. I personally find the Action<T> style the better solution because the library is in control of creating the settings instance which i handed to the function. I've used both a class instance and the Action<> together in the past, where the Action<T> just creates the settings instance and then passes into the other method.

[ericsampson]

@MikeGoldsmith what I noticing is that the way it was originally doesn't work, unless I'm being extra slow today?

Here's an example demonstrating how it was before, and what happens.

[MikeGoldsmith]

@MikeGoldsmith what I noticing is that the way it was originally doesn't work, unless I'm being extra slow today?

Here's an example demonstrating how it was before, and what happens.

That's correct, the previous way of calling services.Configure(settings); didn't work. The updated version passing an Action<HoneycombApiSettings> to configure does work. I believe it's to do with scoping of the services DI graph, but not 100% certain. I've used it previously with an Action and it worked here too 🤷‍♂️ .