fix: allow auto ('0') granularity (#514)

Allow 'auto' granularity to be specified as `0` - Closes #512
honeycombio · Jul 29, 2024 · 4dbb4e4 · 4dbb4e4
1 parent 6b39444
commit 4dbb4e4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/client/v2/client.go b/client/v2/client.go
@@ -208,7 +208,7 @@ func (c *Client) retryHTTPCheck(
 	case http.StatusTooManyRequests:
 		// TODO: use new retry header timestamps to determine when to retry
 		return true, nil
-	case http.StatusBadGateway, http.StatusGatewayTimeout:
+	case http.StatusBadGateway, http.StatusGatewayTimeout, http.StatusInternalServerError:
 		return true, nil
 	default:
 		return false, nil

diff --git a/internal/provider/query_specification_data_source.go b/internal/provider/query_specification_data_source.go
@@ -403,7 +403,7 @@ func (d *querySpecDataSource) Read(ctx context.Context, req datasource.ReadReque
 				"granularity can not be greater than time_range/10",
 			)
 		}
-		if *querySpec.Granularity < (*querySpec.TimeRange / 1000) {
+		if *querySpec.Granularity != 0 && *querySpec.Granularity < (*querySpec.TimeRange/1000) {
 			resp.Diagnostics.AddAttributeError(
 				path.Root("granularity"),
 				"invalid granularity",

diff --git a/internal/provider/query_specification_data_source_test.go b/internal/provider/query_specification_data_source_test.go
@@ -399,7 +399,8 @@ func TestAcc_QuerySpecificationDataSource_zerovalue(t *testing.T) {
       "value": 0
     }
   ],
-  "time_range": 7200
+  "time_range": 7200,
+  "granularity": 0
 }`)
 	require.NoError(t, err)
 
@@ -419,6 +420,8 @@ data "honeycombio_query_specification" "test" {
     op     = ">"
     value  = 0
   }
+
+  granularity = 0
 }
 
 output "query_json" {