Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow auto ('0') granularity #514

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

jharley
Copy link
Collaborator

@jharley jharley commented Jul 29, 2024

Allow 'auto' granularity to be specified as 0

@jharley jharley added the bug label Jul 29, 2024
@jharley
Copy link
Collaborator Author

jharley commented Jul 29, 2024

Also sneaks in a one liner to have the provider V2 client retry on HTTP 500s to -- temporarily at least -- handle the V2 client init. errors.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.13%. Comparing base (6b39444) to head (40a7050).

Files Patch % Lines
client/v2/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #514   +/-   ##
=======================================
  Coverage   80.13%   80.13%           
=======================================
  Files          72       72           
  Lines        5557     5557           
=======================================
  Hits         4453     4453           
  Misses        810      810           
  Partials      294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jharley jharley marked this pull request as ready for review July 29, 2024 17:30
@jharley jharley requested a review from a team as a code owner July 29, 2024 17:30
@jharley jharley merged commit 4dbb4e4 into main Jul 29, 2024
6 checks passed
@jharley jharley deleted the jharley.allow-zero-granularity branch July 29, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

d/query_specification: failing validation on "auto" granularity = 0
3 participants