Add Ionic Skeleton Text to Image component(#1wf7518) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashu22tiwari
changed the title
bashu22tiwari
changed the title
ymaheshwari1
requested changes
Dec 15, 2021
src/components/Image.vue
Outdated
| @@ -1,14 +1,18 @@ | |||
| <template> | |||
| <img :src="imageUrl"/> | |||
| <img :src="imageUrl" v-if="imageUrl" /> | |||
| <ion-skeleton-text v-else animated></ion-skeleton-text> | |||
There was a problem hiding this comment.
We can use self-closing tag here.
There was a problem hiding this comment.
Improved code readability by using self-closing app.
Thank You sir for reviewing my code.
adityasharma7
suggested changes
Dec 20, 2021
src/views/Search.vue
Outdated
| @@ -5,7 +5,7 @@ | |||
| <ion-title>{{ $t("Search") }}</ion-title> | |||
| </ion-toolbar> | |||
| </ion-header> | |||
| <ion-content :fullscreen="true"> | |||
There was a problem hiding this comment.
I think this is unwanted change.
There was a problem hiding this comment.
Though Sir, it is an unwanted change, But it helps in enhancing UI experience, as we do not get our right hand side scroll bar under the header section.
Thankyou Sir, for reviewing my code.
ymaheshwari1
requested changes
Dec 22, 2021
adityasharma7
approved these changes
Feb 3, 2022
ymaheshwari1
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.