Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ionic Skeleton Text to Image component(#1wf7518) #19

Merged
merged 20 commits into from
Feb 3, 2022
Merged

Add Ionic Skeleton Text to Image component(#1wf7518) #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
d082317
Implemented trial for ion-skeleton-text (#1wf7518)
bashu22tiwari Dec 13, 2021
2c3732b
Implemented code for skeletal text
bashu22tiwari Dec 14, 2021
40ec767
Removing the unwanted code (#1wf7518)
bashu22tiwari Dec 15, 2021
6658a18
Improved code by removing the unwanted code (#1wf7518)
bashu22tiwari Dec 15, 2021
62aa7d6
Improved code by removing the unwanted spaces (#1wf7518)
bashu22tiwari Dec 15, 2021
31e0807
Improved code readability (#1wf7518)
bashu22tiwari Dec 15, 2021
9070319
Added changelog (#1wf7518)
bashu22tiwari Dec 15, 2021
4a33e6f
Handled the case for Image if we do not get correct image ()
bashu22tiwari Dec 21, 2021
8493c6d
Improved condition for instance URL (#1wf7518)
bashu22tiwari Dec 21, 2021
ea3d607
Normal changes
bashu22tiwari Dec 22, 2021
6f3a730
Removed unwanted commas (#1wf7518)
bashu22tiwari Dec 22, 2021
df046e0
Fixed the position of input label on login page (#1ym3jwv)
azkyakhan Jan 17, 2022
5c1d277
Added: Changelog (#1ym3jwv)
azkyakhan Jan 17, 2022
33fc477
Merge branch 'main' of https://github.com/hotwax/ionic-sdk into HEAD
bashu22tiwari Jan 21, 2022
95d330b
Resolved conflicts (#1wf7518)
bashu22tiwari Jan 21, 2022
cee683d
Reverted package-lock.json (#1wf7518)
bashu22tiwari Jan 21, 2022
19041b6
Merge pull request #31 from azkyakhan/#1ym3jwv
dt2patel Jan 23, 2022
329f4a3
Implemented code for skeletal text (#1wf7518)
bashu22tiwari Jan 27, 2022
fcf18c2
Improved code (#1wf7518)
bashu22tiwari Jan 27, 2022
5f2495e
Removed unwanted changes (#1wf7518)
bashu22tiwari Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelogs/unreleased/-1wf7518.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
title: Implemented code to use skeleton text in Image component
ticket_id: "#1wf7518"
merge_request: 19
author: Bashu Tiwari
type: added
11 changes: 8 additions & 3 deletions src/components/Image.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
<template>
<img :src="imageUrl"/>
<img :src="imageUrl" v-if="imageUrl" />
<ion-skeleton-text v-else animated />
</template>

<script lang="ts">
import { defineComponent } from "vue";
import { IonSkeletonText } from '@ionic/vue'

export default defineComponent({
name: "Image",
props: ['src'],
components: {},
components: {
IonSkeletonText
},
created() {
if (
process.env.VUE_APP_RESOURCE_URL
Expand All @@ -25,7 +29,7 @@ export default defineComponent({
data() {
return {
resourceUrl: '',
imageUrl: require("@/assets/images/defaultImage.png")
adityasharma7 marked this conversation as resolved.
Show resolved Hide resolved
imageUrl: ''
}
},
methods: {
Expand All @@ -51,6 +55,7 @@ export default defineComponent({
this.checkIfImageExists(this.src).then(() => {
this.imageUrl = this.src;
}).catch(() => {
this.imageUrl = require("@/assets/images/defaultImage.png") ;
console.error("Image doesn't exist");
})
} else {
Expand Down