Tests: rely on load hooks instead of class constants #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to [hotwired#513][] Rely on [on_load hooks][] to extend test helpers. Despite the fact that Action Cable is an optional dependency and Action Dispatch is not, this commit replaces all `class`-style extensions with `on_load` hooks for the sake of consistency. There isn't a hook for `ActionCable::Channel::TestCase`, so waiting for `action_cable_channel` to fire is the best that we can do. [hotwired#513]: hotwired#513 [on_load hooks]: https://guides.rubyonrails.org/engines.html#available-load-hooks
|
In #512 and #513, we're dealing with runtime configuration, i.e. apps that load @seanpdoyle In which situation do we need this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #513
Rely on on_load hooks to extend test helpers. Despite the fact that Action Cable is an optional dependency and Action Dispatch is not, this commit replaces all
class-style extensions withon_loadhooks for the sake of consistency.There isn't a hook for
ActionCable::Channel::TestCase, so waiting foraction_cable_channelto fire is the best that we can do.