Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: rely on load hooks instead of class constants #514

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tests: rely on load hooks instead of class constants #514

wants to merge 1 commit into from

Commits on Nov 11, 2023

  1. Tests: rely on load hooks instead of class constants 

    Follow-up to [hotwired#513][]

Rely on [on_load hooks][] to extend test helpers. Despite the fact that
Action Cable is an optional dependency and Action Dispatch is not, this
commit replaces all `class`-style extensions with `on_load` hooks for
the sake of consistency.

There isn't a hook for `ActionCable::Channel::TestCase`, so waiting for
`action_cable_channel` to fire is the best that we can do.

[hotwired#513]: hotwired#513
[on_load hooks]: https://guides.rubyonrails.org/engines.html#available-load-hooks
    @seanpdoyle
    seanpdoyle committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    7b29db3 View commit details
    Browse the repository at this point in the history