Re-enable cppcheck

[antocuni]

In commit a91f8f9 (PR #187 ) I had to disable cppcheck, because it failed for no good reason.

I have no idea of what's happening, we should try again in some days/weeks and maybe re-enable it.

[thedrow]

On CPPCheck 2.5 make cppcheck passes successfully.

This sounds like a weird bug that should be reported.

[antocuni]

do you feel like making a PR with cppcheck 2.5 and see if it passes the CI?

[thedrow]

Since snap didn't properly work, we'd probably need to install it using Linuxbrew, I guess.
If that's OK with you, I can do it.

[antocuni]

Sorry for the late response. I don't know what is linuxbrew but as long as it works, that's ok with me :)

[thedrow]

Homebrew for linux...

[fangerer]

I've re-enabled cppcheck but using Ubuntu's version 1.90. I think this is better than nothing for now. We may think about moving to a newer version.

[mattip]

cppcheck is failing CI, and I think it is not a good investment of the core team to fix it. Perhaps someone will step up at some point but I think we should disable it.

[fangerer]

@mattip I can already reproduce the problem in a virtual machine using nearly the same system and versions as GitHub's docker images. Maybe I can quickly find the problem but as you said, I won't invest too much time.