Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip cppcheck #413

Merged
merged 1 commit into from
Mar 3, 2023
Merged

skip cppcheck #413

merged 1 commit into from
Mar 3, 2023

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Mar 2, 2023

Related to #188 and #395. The check has been failing for a few months. It seems to check way too much

fangerer
fangerer approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@fangerer fangerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I absolutely agree because if the check is not a blocker and we know that it is failing, no one is ever looking at the log output to check if there are new problems. So it is useless.

@fangerer fangerer merged commit 0c78f9f into hpyproject:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fangerer fangerer fangerer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattip @fangerer