Improve clipping/culling handling in software renderer #11287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to just to depth clamp. When depth clamp happens, it affects clipping a little, but only for vertices that needed clamping.
In some cases on first draw (e.g. from a test), this might be null and crash. It was supposed to be the other program.
Depth clamping bypasses the 4096x4096 box check.
Depth clamping doesn't change whether it clips. Also, avoid culling when a vertex is behind the near plane.
They were all off before for 4x3.
Had some tests failing when on the edge due to this.
|
So, this is something what Will fix it or reduce it? |
|
@marosis This just improves it in the software renderer, but it's good to have as a reference for the other backends. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also renames the flag to isDepthClampEnabled, which I think is the proper name now.
See notes in #9527. Fixes #9622, from testing several of those games. Does pass various guardband tests.
Also corrected some GE debugger glitches along the way.
-[Unknown]