Fix: remove filename prefix for reducehashranges #14341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, just fixing a small mistake of mine from #14332.
About adding the dimensions as a prefix for textures using a non-default reducehashvalue:
It was because I thought multiple differents reducehash value could create a mess with other textures that use the other values but it doesn't look like it.
I tried to be safe but I now realize that this way [reducehashranges] does not work with [hashes] (unless some changes are made) or at least, isn't intuitive since this won't work:
but this works (even though the dumped file is still named with the prefix):
So to correct my mistake (sorry), I simply removed the prefix I previously added which should fix that.
Filenames will be back to: addresscluthash.png
Like all the others.
Double-checked how it would interact with [hashranges] and it looks ok (I don't think anyone is going to be using both though).