Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move --docker-login from end of singularity shell command to before image name #18

Merged
merged 1 commit into from
May 6, 2022

Conversation

danikam
Copy link
Contributor

@danikam danikam commented Mar 19, 2021

It was found by Yury Smirnov that if the environment variables SINGULARITY_DOCKER_USERNAME, SINGULARITY_DOCKER_PASSWORD aren't pre-set, the --docker-login only works in the singularity shell command if put in front of the image name, not after.

…re image name

It was found by Yury Smirnov that if the environment variables `SINGULARITY_DOCKER_USERNAME`, `SINGULARITY_DOCKER_PASSWORD` aren't pre-set, the `--docker-login` only works in the `singularity shell` command if put in front of the image name, not after.
@danikam danikam changed the title Move --docker-login from end of singularity shell command to befo… Move --docker-login from end of singularity shell command to before image name Mar 19, 2021
@klieret klieret requested a review from bregnery July 31, 2021 12:48
@klieret klieret merged commit 97142b8 into hsf-training:gh-pages May 6, 2022
@klieret
Copy link
Member

klieret commented May 6, 2022

Hi @bregnery. I've just merged this, because you had already approved the changes.

Thanks for the PR @danikam!

@klieret klieret mentioned this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants