add all contribs #36
Closed
add all contribs #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help users of the lesson template understand how to choose/when to update the value of life_cycle
Comments prepended with `##` appear in the output of `make commands`. This commit changes `#` to `##` in front of `lesson-check` so that it appears in the output of `make commands`.
Git for Windows doesn't provide fgrep, which is a shortcut to call `grep -F` on Mac and Linux. Instead, we have to use full arguments.
To avoid problems with various symbols, we have to specify the encoding when we read files. The actual codec name is `utf_8` but aliases like `utf8`, `utf-8`, etc are accepted. Here, I'm using `utf-8` alias. https://docs.python.org/3.8/library/codecs.html#standard-encodings This fixes `make lesson-check` when running under 'Git for Windows' for lessons that have non-cp1252 characters.
…re image name (#18) It was found by Yury Smirnov that if the environment variables `SINGULARITY_DOCKER_USERNAME`, `SINGULARITY_DOCKER_PASSWORD` aren't pre-set, the `--docker-login` only works in the `singularity shell` command if put in front of the image name, not after.
* Improve link formatting; add some paragraphs * Clear up instructions for non-CERN users
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
updates: - [github.com/codespell-project/codespell: v2.1.0 → v2.2.1](codespell-project/codespell@v2.1.0...v2.2.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lesson-check(#481)--docker-loginfrom end ofsingularity shellcommand to before image name (Move--docker-loginfrom end ofsingularity shellcommand to before image name #18)