typescript(vx-voronoi): re-write package in TypeScript #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
reviewed
Oct 2, 2019
| /** className to apply to path element. */ | ||
| className?: string; | ||
| /** Array of coordinate arrays for the polygon (e.g., [[x,y], [x1,y1], ...]), used to generate polygon path. */ | ||
| polygon?: number[][]; |
There was a problem hiding this comment.
looks like this is not possible when the type is optional, build fails with this error
There was a problem hiding this comment.
made it required to avoid
There was a problem hiding this comment.
I take that back, I think it comes from the @types/d3-voronoi types
kristw
reviewed
Oct 2, 2019
williaster
force-pushed
the
chris--typescript-vx-voronoi
branch
from
c29c465
to
38a068c
Compare
williaster
force-pushed
the
chris--typescript-vx-voronoi
branch
from
d2752ea
to
8502ad5
Compare
|
Hrmm, not really sure how to fix this one. I think this error is coming from the |
kristw
approved these changes
Oct 22, 2019
hshoff
approved these changes
Nov 13, 2019
|
Looks like the tests are failing on const [, [x1, y1]] = v.extent();Might try changing this to: const [[x0, y0], [x1, y1]] = v.extent(); |
williaster
force-pushed
the
chris--typescript-vx-voronoi
branch
from
8502ad5
to
00967c8
Compare
3 tasks
added 11 commits
November 13, 2019 14:43
williaster
force-pushed
the
chris--typescript-vx-voronoi
branch
from
d838eb7
to
77d04c0
Compare
|
old school syntax worked |
🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
This PR builds off #488 which introduces Typescript build config, and re-writes the
@vx/voronoipackage in TypeScript.It also removes an unneeded
@vx/groupdependency. Closes #511.💥 Breaking Changes
React.Fragments, which requires bumping thepeerDepforreactto^16.3.0-0Tests
/voronoidemo@hshoff @schillerk @milesj @kristw @Rudeg